-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: require and then remove karpenter startup taint #1336
feat: require and then remove karpenter startup taint #1336
Conversation
Hi @rschalo. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/reopen |
Pull Request Test Coverage Report for Build 9764619347Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9766354735Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
/lgtm |
Co-authored-by: Nick Tran <10810510+njtran@users.noreply.github.com>
Pull Request Test Coverage Report for Build 9785861189Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njtran, rschalo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…s#1336) Co-authored-by: Nick Tran <10810510+njtran@users.noreply.github.com>
Fixes #1049
Description
Based on implementation discussion, it is required that userdata scripts for starting kubelet include
karpenter.sh/unregistered=true:NoExecute
as part of the--register-with-taints
flag.How was this change tested?
Unit testing and local
aws/karpenter-provider-aws
deployment. This will be ship with aws/karpenter-provider-aws#6388By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.