Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: require and then remove karpenter startup taint #1336

Merged

Conversation

rschalo
Copy link
Contributor

@rschalo rschalo commented Jun 19, 2024

Fixes #1049

Description
Based on implementation discussion, it is required that userdata scripts for starting kubelet include karpenter.sh/unregistered=true:NoExecute as part of the --register-with-taints flag.

How was this change tested?
Unit testing and local aws/karpenter-provider-aws deployment. This will be ship with aws/karpenter-provider-aws#6388

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 19, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 19, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @rschalo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 19, 2024
@rschalo rschalo closed this Jun 24, 2024
@rschalo rschalo reopened this Jun 24, 2024
@rschalo rschalo marked this pull request as ready for review June 26, 2024 21:21
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2024
@jonathan-innis jonathan-innis deleted the branch kubernetes-sigs:main June 26, 2024 22:07
@jonathan-innis
Copy link
Member

/reopen

@coveralls
Copy link

coveralls commented Jul 2, 2024

Pull Request Test Coverage Report for Build 9764619347

Details

  • 19 of 23 (82.61%) changed or added relevant lines in 4 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.05%) to 78.664%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/nodeclaim/lifecycle/registration.go 9 13 69.23%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/nodeclaim/lifecycle/registration.go 1 82.54%
pkg/test/cachesyncingclient.go 2 82.29%
pkg/controllers/nodeclaim/disruption/controller.go 3 54.17%
Totals Coverage Status
Change from base Build 9754782073: 0.05%
Covered Lines: 8598
Relevant Lines: 10930

💛 - Coveralls

pkg/controllers/nodeclaim/lifecycle/registration.go Outdated Show resolved Hide resolved
pkg/controllers/nodeclaim/lifecycle/registration_test.go Outdated Show resolved Hide resolved
pkg/controllers/provisioning/scheduling/suite_test.go Outdated Show resolved Hide resolved
pkg/test/nodes.go Outdated Show resolved Hide resolved
pkg/test/nodes.go Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jul 2, 2024

Pull Request Test Coverage Report for Build 9766354735

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 16 of 20 (80.0%) changed or added relevant lines in 4 files are covered.
  • 38 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.07%) to 78.68%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/nodeclaim/lifecycle/registration.go 8 12 66.67%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/nodeclaim/lifecycle/registration.go 1 82.26%
pkg/test/cachesyncingclient.go 2 82.29%
pkg/controllers/nodeclaim/disruption/controller.go 3 54.17%
pkg/controllers/provisioning/provisioner.go 32 79.25%
Totals Coverage Status
Change from base Build 9754782073: 0.07%
Covered Lines: 8606
Relevant Lines: 10938

💛 - Coveralls

@jmdeal
Copy link
Member

jmdeal commented Jul 2, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2024
pkg/controllers/nodeclaim/lifecycle/registration_test.go Outdated Show resolved Hide resolved
pkg/controllers/nodeclaim/lifecycle/registration.go Outdated Show resolved Hide resolved
pkg/test/nodes.go Outdated Show resolved Hide resolved
pkg/test/expectations/expectations.go Outdated Show resolved Hide resolved
pkg/controllers/provisioning/suite_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 3, 2024
pkg/controllers/nodeclaim/lifecycle/registration_test.go Outdated Show resolved Hide resolved
pkg/controllers/nodeclaim/lifecycle/registration_test.go Outdated Show resolved Hide resolved
pkg/test/nodes.go Show resolved Hide resolved
rschalo and others added 3 commits July 3, 2024 13:31
Co-authored-by: Nick Tran <10810510+njtran@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 3, 2024
@coveralls
Copy link

coveralls commented Jul 3, 2024

Pull Request Test Coverage Report for Build 9785861189

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 17 of 19 (89.47%) changed or added relevant lines in 4 files are covered.
  • 100 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.1%) to 78.754%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/nodeclaim/lifecycle/registration.go 11 13 84.62%
Files with Coverage Reduction New Missed Lines %
pkg/utils/disruption/disruption.go 1 93.75%
pkg/controllers/nodeclaim/lifecycle/registration.go 1 85.71%
pkg/test/expectations/expectations.go 2 93.7%
pkg/scheduling/requirements.go 2 98.01%
pkg/controllers/metrics/pod/controller.go 15 77.42%
pkg/apis/v1/nodepool.go 15 67.86%
pkg/controllers/nodepool/counter/controller.go 15 62.07%
pkg/controllers/nodeclaim/termination/controller.go 17 65.0%
pkg/controllers/provisioning/provisioner.go 32 79.25%
Totals Coverage Status
Change from base Build 9754782073: 0.1%
Covered Lines: 8611
Relevant Lines: 10934

💛 - Coveralls

Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njtran, rschalo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit e40f4b0 into kubernetes-sigs:main Jul 3, 2024
13 checks passed
BEvgeniyS pushed a commit to BEvgeniyS/karpenter that referenced this pull request Jul 5, 2024
…s#1336)

Co-authored-by: Nick Tran <10810510+njtran@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
6 participants