chore: update kubelet hash annotation on nodeclaim #6508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
jigisha620
force-pushed
the
feat-kubelet-hash
branch
from
b325ca0
to
893c932
Compare
Pull Request Test Coverage Report for Build 9949156096Details
💛 - Coveralls |
jigisha620
force-pushed
the
feat-kubelet-hash
branch
from
893c932
to
6361e8c
Compare
jigisha620
force-pushed
the
feat-kubelet-hash
branch
from
6361e8c
to
23bcab1
Compare
|
I'm struggling to review this without context. Can you add to the description why these changes are necessary? |
jigisha620
force-pushed
the
feat-kubelet-hash
branch
from
23bcab1
to
12a5f4e
Compare
engedaam
reviewed
Jul 15, 2024
jigisha620
force-pushed
the
feat-kubelet-hash
branch
2 times, most recently
from
1b751f8
to
62badb2
Compare
jigisha620
force-pushed
the
feat-kubelet-hash
branch
from
62badb2
to
dc65629
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
Added change to update nodeClaim hash when kubelet configuration on ec2nodeclass changes. This change has been added to orchestrate the conversion from v1beta1 to v1 apis specifically for the case where we have moved kubelet configuration from nodePool to nodeClass. We don't want to drift the nodeClaim if kubelet config is moved from nodePool to nodeClass if it's unchanged.
How was this change tested?
Added functional tests for this change.
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.