Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix error returned when resolving nodePool from nodeClaim (utils) #6517

Merged
merged 1 commit into from
Jul 16, 2024
Merged

chore: Fix error returned when resolving nodePool from nodeClaim (utils) #6517

merged 1 commit into from
Jul 16, 2024

Conversation

jigisha620
Copy link
Contributor

Fixes #N/A

Description
Taking in the change that was suggested in a previous PR - #6508

How was this change tested?
NA

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jigisha620 jigisha620 requested a review from a team as a code owner July 16, 2024 01:53
@jigisha620 jigisha620 requested a review from jmdeal July 16, 2024 01:53
@netlify Netlify
Copy link

netlify bot commented Jul 16, 2024 •
edited

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 57b525d
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6695d2a1282c510008c3ddc9

engedaam
engedaam approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jigisha620 jigisha620 enabled auto-merge (rebase) July 16, 2024 01:55
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9949441981

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.967%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/utils/utils.go 0 1 0.0%
Totals Coverage Status
Change from base Build 9949347400: 0.0%
Covered Lines: 5852
Relevant Lines: 7318
💛 - Coveralls

@jigisha620 jigisha620 merged commit 9b4baab into aws:main Jul 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engedaam engedaam engedaam approved these changes

@jmdeal jmdeal Awaiting requested review from jmdeal jmdeal is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jigisha620 @coveralls @engedaam