feat: usage plans support for Api Auth #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShreyaGangishetty
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #1179 +/- ##
===========================================
- Coverage 94.44% 94.42% -0.03%
===========================================
Files 78 78
Lines 4557 4660 +103
Branches 911 929 +18
===========================================
+ Hits 4304 4400 +96
- Misses 119 121 +2
- Partials 134 139 +5
Continue to review full report at Codecov.
|
praneetap
reviewed
Oct 9, 2019
praneetap
reviewed
Oct 9, 2019
praneetap
reviewed
Oct 9, 2019
keetonian
reviewed
Oct 9, 2019
praneetap
reviewed
Oct 9, 2019
added 9 commits
January 15, 2020 13:38
ShreyaGangishetty
force-pushed
the
usage-plans-branch
branch
from
577ba34 to
80d2cf4
Compare
ShreyaGangishetty
force-pushed
the
usage-plans-branch
branch
from
b60818f to
90dde9e
Compare
keetonian
reviewed
Jan 15, 2020
| StageName: Prod | ||
| Auth: | ||
| UsagePlan: | ||
| CreateUsagePlan: SHARED |
There was a problem hiding this comment.
Does this not create a UsagePlan now?
There was a problem hiding this comment.
it creates a usage plan with logical id ServerlessUsagePlan
keetonian
reviewed
Jan 15, 2020
keetonian
approved these changes
Jan 15, 2020
praneetap
reviewed
Jan 16, 2020
praneetap
approved these changes
Jan 20, 2020
8 tasks
This was referenced Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1141, #248, #547
Description of changes:
added support for usage plans
Description of how you validated changes:
added test input templates and also deployed the generated templates in CloudFormation and validated
Checklist:
make prpassesexamples/2016-10-31By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.