-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: usage plans support for Api Auth #1179
Merged
ShreyaGangishetty
merged 12 commits into
aws:develop
from
ShreyaGangishetty:usage-plans-branch
Jan 21, 2020
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
78fb7c2
feat: usage plans support
7381f5d
updated documentation
0006090
updated tests for intrinsics
ecbb66d
updated the code with error messages
049f763
added documentation and example for usage plans
beb5d38
removed packaged template
1f2e7d7
fixed the code for create usage plan NONE
25d3c4d
update usage plans
80d2cf4
feat: usageplans for auth
90dde9e
fix: documenation for usageplans
64f8573
fix: review comments
d3ed4e0
cr comment
praneetap File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
Parameters: | ||
UsagePlanType: | ||
Type: String | ||
Default: PER_API | ||
|
||
Globals: | ||
Api: | ||
OpenApiVersion: 3.0.0 | ||
Auth: | ||
ApiKeyRequired: true | ||
UsagePlan: | ||
CreateUsagePlan: !Ref UsagePlanType | ||
|
||
Resources: | ||
MyApiOne: | ||
Type: AWS::Serverless::Api | ||
Properties: | ||
StageName: Prod | ||
|
||
MyApiTwo: | ||
Type: AWS::Serverless::Api | ||
Properties: | ||
StageName: Prod | ||
Auth: | ||
UsagePlan: | ||
CreateUsagePlan: SHARED | ||
|
||
MyFunctionOne: | ||
Type: AWS::Serverless::Function | ||
Properties: | ||
Handler: index.handler | ||
Runtime: nodejs12.x | ||
InlineCode: | | ||
exports.handler = async (event) => { | ||
return { | ||
statusCode: 200, | ||
body: JSON.stringify(event), | ||
headers: {} | ||
} | ||
} | ||
Events: | ||
ApiKey: | ||
Type: Api | ||
Properties: | ||
RestApiId: | ||
Ref: MyApiOne | ||
Method: get | ||
Path: /path/one | ||
|
||
MyFunctionTwo: | ||
Type: AWS::Serverless::Function | ||
Properties: | ||
Handler: index.handler | ||
Runtime: nodejs12.x | ||
InlineCode: | | ||
exports.handler = async (event) => { | ||
return { | ||
statusCode: 200, | ||
body: JSON.stringify(event), | ||
headers: {} | ||
} | ||
} | ||
Events: | ||
ApiKey: | ||
Type: Api | ||
Properties: | ||
RestApiId: | ||
Ref: MyApiTwo | ||
Method: get | ||
Path: /path/two | ||
Outputs: | ||
ApiOneUrl: | ||
Description: "API endpoint URL for Prod environment" | ||
Value: | ||
Fn::Sub: 'https://${MyApiOne}.execute-api.${AWS::Region}.amazonaws.com/Prod/' | ||
|
||
ApiTwoUrl: | ||
Description: "API endpoint URL for Prod environment" | ||
Value: | ||
Fn::Sub: 'https://${MyApiTwo}.execute-api.${AWS::Region}.amazonaws.com/Prod/' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this not create a UsagePlan now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it creates a usage plan with logical id
ServerlessUsagePlan