feat: add payloadformatversion to httpapi events #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keetonian
approved these changes
Mar 16, 2020
jfuss
reviewed
Mar 16, 2020
| @@ -210,7 +210,7 @@ def add_lambda_integration( | |||
| path_dict[method][self._X_APIGW_INTEGRATION] = { | |||
| "type": "aws_proxy", | |||
| "httpMethod": "POST", | |||
| "payloadFormatVersion": "1.0", | |||
| "payloadFormatVersion": "2.0", | |||
There was a problem hiding this comment.
Does this mean we default to 2.0 payloadFormatVersion in SAM?
There was a problem hiding this comment.
Ahh.. yes, as stated in the docs below.
There was a problem hiding this comment.
Yes, the default value is "2.0" in SAM
jfuss
approved these changes
Mar 16, 2020
ShreyaGangishetty
pushed a commit
to ShreyaGangishetty/serverless-application-model
that referenced
this pull request
Mar 16, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Description of how you validated changes:
Checklist:
make prpassesexamples/2016-10-31By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.