Modifying kubelet to use config files instead of kubelet flags which are about to deprecate. #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 1, 2018 02:03
| --feature-gates=RotateKubeletServerCertificate=true \ | ||
| --anonymous-auth=false \ | ||
| --client-ca-file=/etc/kubernetes/pki/ca.crt $KUBELET_ARGS $KUBELET_MAX_PODS $KUBELET_EXTRA_ARGS | ||
| ExecStartPre=/sbin/iptables -P FORWARD ACCEPT |
There was a problem hiding this comment.
@errordeveloper - I saw many miss this iptables rule causing problem, hence I added it to ExecStartPre to enforce this command run every time kubelet starts and change the rule.
There was a problem hiding this comment.
Why is it part of this PR and there was no discussion about it here? Maybe a comment in the unit file would help also, but I still don't quite understand the purpose, it seems very ad-hoc and as far as I can tell redundant in the context of this AMI.
There was a problem hiding this comment.
I wonder if the above questions is addressed some where else?
why is the FORWARD rule to ACCEPT?
errm
added a commit
to errm/ekstrap
that referenced
this pull request
Dec 20, 2018
see: awslabs/amazon-eks-ami#90 This should fix #49 that I think is cased by relying on depricated kubelet flags.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Changing Kubelet to use config files instead of using kubelet flags as they are deprecated.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.