Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Update config to use KubeletConfig in line with official AMI #50

Merged
merged 1 commit into from
Dec 21, 2018

Conversation

errm
Copy link
Owner

@errm errm commented Dec 20, 2018

see: awslabs/amazon-eks-ami#90

This should fix #49 that I think is cased by relying on deprecated
kubelet flags.

see: awslabs/amazon-eks-ami#90

This should fix #49 that I think is cased by relying on depricated
kubelet flags.
@errm errm requested a review from mtpereira December 20, 2018 17:26
@errm
Copy link
Owner Author

errm commented Dec 20, 2018

FYI: @ettiee

@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #50 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   90.82%   90.82%           
=======================================
  Files           7        7           
  Lines         229      229           
=======================================
  Hits          208      208           
  Misses         13       13           
  Partials        8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cd474a...17f40b1. Read the comment docs.

@mtpereira
Copy link
Collaborator

@errm So this will break support for older Kubernetes versions, right? This should be mentioned in the README and/or in the release notes of this particular version. Also, this release should be a minor SemVer upgrade.

@errm
Copy link
Owner Author

errm commented Dec 20, 2018

I think this should still work with k8s 1.10 ... I will need to test that... but this config file was added in 1.10 ...

@errm
Copy link
Owner Author

errm commented Dec 20, 2018

@errm
Copy link
Owner Author

errm commented Dec 20, 2018

Also since the major version is still 0 we can do whatever we like anyway https://semver.org/#spec-item-4

@mtpereira
Copy link
Collaborator

Yep confirmed this landed in 1.10 https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/#before-you-begin

How far back are we willing to keep ekstrap working?

@errm
Copy link
Owner Author

errm commented Dec 21, 2018

How far back are we willing to keep ekstrap working?

It only needs to work with the versions you can currently run on EKS ... currently that means 1.10 and 1.11 we should just support whatever AWS does...

@errm errm merged commit 03f011c into master Dec 21, 2018
@errm errm deleted the config-updates branch December 21, 2018 09:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cert error on EKS with k8s version 1.11.5
2 participants