Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShardInfo class not public #120

Closed
dlsteuer opened this issue Nov 23, 2016 · 2 comments
Closed

ShardInfo class not public #120

dlsteuer opened this issue Nov 23, 2016 · 2 comments
Labels
bug
Milestone
Release 1.7.3

Comments

@dlsteuer
Copy link

Just checking to see if this is just an oversight, but the ShardInfo class is non-public and so it's not possible to provide a custom ShardPrioritization implementation that compiles because of this.
@pfifer pfifer added the bug label Nov 23, 2016
@pfifer
Copy link
Contributor

pfifer commented Nov 23, 2016

Looking at it, I think it's an oversight. The existing strategies just happen to be in the same package so they don't have that issue.

I'll look at making the class public for a future release. For the short term you could place your strategy in the same package: com.amazonaws.services.kinesis.clientlibrary.lib.worker

pfifer added a commit to pfifer/amazon-kinesis-client that referenced this issue Jan 9, 2017
@pfifer
Make ShardInfo Public, and Update Documentation
b3610fb 
Made the ShardInfo class public, and updated the documentation for a
number of the properties.

This will allow users to implement custom shard prioritization
strategies.

Fixes:
Issue awslabs#120
@pfifer pfifer mentioned this issue Jan 9, 2017
Merged
pfifer added a commit that referenced this issue Jan 9, 2017
@pfifer
Make ShardInfo Public, and Update Documentation (#127)
a7b16b4 
Made the ShardInfo class public, and updated the documentation for a
number of the properties.

This will allow users to implement custom shard prioritization
strategies.

Fixes:
Issue #120
pfifer added a commit to pfifer/amazon-kinesis-client that referenced this issue Jan 20, 2017
@pfifer
Release 1.7.3 of the Amazon Kinesis Client
ac019f1 
* Upgrade to the newest AWS Java SDK.
  * Issue awslabs/amazon-kinesis-client-python#27
  * PR awslabs#126
  * PR awslabs#125
* Added a direct dependency on commons-logging.
  * Issue awslabs#123
  * PR awslabs#124
* Make ShardInfo public to allow for custom ShardPrioritization strategies.
  * Issue awslabs#120
  * PR awslabs#127
pfifer added a commit that referenced this issue Jan 20, 2017
@pfifer
Release 1.7.3 of the Amazon Kinesis Client (#131)
3d18e48 
* Upgrade to the newest AWS Java SDK.
  * Issue awslabs/amazon-kinesis-client-python#27
  * PR #126
  * PR #125
* Added a direct dependency on commons-logging.
  * Issue #123
  * PR #124
* Make ShardInfo public to allow for custom ShardPrioritization strategies.
  * Issue #120
  * PR #127
@pfifer pfifer added this to the Release 1.7.3 milestone Jan 23, 2017
@pfifer
Copy link
Contributor

pfifer commented Jan 23, 2017

This is now fixed in Release 1.7.3.

Feel free to reopen if you have any additional questions.

@pfifer pfifer closed this as completed Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Release 1.7.3
Development

No branches or pull requests
2 participants
@dlsteuer @pfifer