Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commons-logging should be added to pom.xml #123

Closed
seanpd opened this issue Dec 14, 2016 · 3 comments
Closed

commons-logging should be added to pom.xml #123

seanpd opened this issue Dec 14, 2016 · 3 comments
Labels
bug
Milestone
Release 1.7.3

Comments

@seanpd
Copy link

seanpd commented Dec 14, 2016 •
edited
Loading

This dependency should be called

  <dependency>
      <groupId>commons-logging</groupId>
      <artifactId>commons-logging</artifactId>
      <version>1.1.1</version>
  </dependency>

I used the Maven Shade plugin to create a fat jar and found the commons-logging missing.
@pfifer pfifer added the bug label Jan 5, 2017
@pfifer pfifer added this to the Release 1.7.3 milestone Jan 9, 2017
@pfifer
Copy link
Contributor

pfifer commented Jan 9, 2017

Fix was merged in PR #124

pfifer added a commit to pfifer/amazon-kinesis-client that referenced this issue Jan 20, 2017
@pfifer
Release 1.7.3 of the Amazon Kinesis Client
ac019f1 
* Upgrade to the newest AWS Java SDK.
  * Issue awslabs/amazon-kinesis-client-python#27
  * PR awslabs#126
  * PR awslabs#125
* Added a direct dependency on commons-logging.
  * Issue awslabs#123
  * PR awslabs#124
* Make ShardInfo public to allow for custom ShardPrioritization strategies.
  * Issue awslabs#120
  * PR awslabs#127
pfifer added a commit that referenced this issue Jan 20, 2017
@pfifer
Release 1.7.3 of the Amazon Kinesis Client (#131)
3d18e48 
* Upgrade to the newest AWS Java SDK.
  * Issue awslabs/amazon-kinesis-client-python#27
  * PR #126
  * PR #125
* Added a direct dependency on commons-logging.
  * Issue #123
  * PR #124
* Make ShardInfo public to allow for custom ShardPrioritization strategies.
  * Issue #120
  * PR #127
@pfifer
Copy link
Contributor

pfifer commented Jan 23, 2017

This is now fixed, and release in 1.7.3.

Feel free to reopen if you have any additional questions.

@pfifer pfifer closed this as completed Jan 23, 2017
@danieljamesscott
Copy link

Is it possible to switch to slf4j? Or is this a major change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Release 1.7.3
Development

No branches or pull requests
3 participants
@danieljamesscott @seanpd @pfifer