Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add if-match to auto-range get #226

Merged
merged 5 commits into from
Nov 2, 2022
Merged

add if-match to auto-range get #226

merged 5 commits into from
Nov 2, 2022

Conversation

TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Nov 2, 2022

Issue #, if available:

  • If the object was updated when we get some range. The other range of the object could be from another version and we don't error out.

Description of changes:

  • Add if-match header to make sure error out when the corner case happens.

TODO: TEST.
Tests are done: #247

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@TingDaoK TingDaoK marked this pull request as ready for review November 2, 2022 16:52
@TingDaoK TingDaoK changed the title add if match to auto get add if-match to auto-range get Nov 2, 2022
@TingDaoK TingDaoK merged commit a3a8a2b into main Nov 2, 2022
@TingDaoK TingDaoK deleted the if-match branch November 2, 2022 20:40
jamesbornholt added a commit to awslabs/mountpoint-s3 that referenced this pull request Feb 18, 2023
We haven't done this since starting the project, and there's been a few
important fixes since then, most notably awslabs/aws-c-s3#226 for
detecting concurrent mutations during GETs.

On our bindings side not much has changed. The Uri code moved from
aws-c-io to aws-c-common, and there was also a change to how missing
path fragments are parsed in URIs (awslabs/aws-c-common#986).

Signed-off-by: James Bornholt <bornholt@amazon.com>
monthonk pushed a commit to awslabs/mountpoint-s3 that referenced this pull request Feb 21, 2023
We haven't done this since starting the project, and there's been a few
important fixes since then, most notably awslabs/aws-c-s3#226 for
detecting concurrent mutations during GETs.

On our bindings side not much has changed. The Uri code moved from
aws-c-io to aws-c-common, and there was also a change to how missing
path fragments are parsed in URIs (awslabs/aws-c-common#986).

Signed-off-by: James Bornholt <bornholt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants