added test for object modified #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
==========================================
+ Coverage 85.18% 85.25% +0.06%
==========================================
Files 17 17
Lines 4307 4307
==========================================
+ Hits 3669 3672 +3
+ Misses 638 635 -3
|
graebm
approved these changes
Jan 13, 2023
tests/s3_mock_server_tests.c
Outdated
Comment on lines
161
to
162
| /* Check the README part for getobject mismatch */ | ||
| struct aws_byte_cursor object_path = aws_byte_cursor_from_c_str("/get_object_modified"); |
There was a problem hiding this comment.
what README part are you talking about?
There was a problem hiding this comment.
The mock server README. Updated the README and the comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.