-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bindings for EndpointsRuleEngine #79
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 5, 2022
jbelkins
reviewed
Oct 6, 2022
Source/AwsCommonRuntimeKit/sdkutils/CRTAWSEndpointsResolvedEndpoint.swift
Show resolved
Hide resolved
Source/AwsCommonRuntimeKit/sdkutils/CRTAWSEndpointsResolvedEndpoint.swift
Show resolved
Hide resolved
Source/AwsCommonRuntimeKit/sdkutils/CRTAWSEndpointsResolvedEndpoint.swift
Outdated
Show resolved
Hide resolved
jbelkins
approved these changes
Oct 7, 2022
ganeshnj
force-pushed
the
jangirg/feat/endpoints-2-crt
branch
from
October 10, 2022 20:07
5388a97
to
5718103
Compare
ganeshnj
commented
Oct 10, 2022
Comment on lines
20
to
-26
- uses: actions/checkout@v1 | ||
- name: GitHub Action for SwiftLint | ||
uses: norio-nomura/action-swiftlint@3.1.0 | ||
- name: GitHub Action for SwiftLint with --strict | ||
uses: norio-nomura/action-swiftlint@3.1.0 | ||
with: | ||
args: --strict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strict is ignoring the .swiftlint
config file and redundant to the line 20 after removing strict.
waahm7
requested changes
Oct 13, 2022
Source/AwsCommonRuntimeKit/sdkutils/CRTAWSEndpointsRequestContext.swift
Outdated
Show resolved
Hide resolved
Source/AwsCommonRuntimeKit/sdkutils/CRTAWSEndpointsRequestContext.swift
Outdated
Show resolved
Hide resolved
Source/AwsCommonRuntimeKit/sdkutils/CRTAWSEndpointsRequestContext.swift
Outdated
Show resolved
Hide resolved
Source/AwsCommonRuntimeKit/sdkutils/CRTAWSEndpointsResolvedEndpoint.swift
Show resolved
Hide resolved
Source/AwsCommonRuntimeKit/sdkutils/CRTAWSEndpointsResolvedEndpoint.swift
Show resolved
Hide resolved
Source/AwsCommonRuntimeKit/sdkutils/CRTAWSEndpointsResolvedEndpoint.swift
Show resolved
Hide resolved
Test/AwsCommonRuntimeKitTests/sdkutils/CRTAWSEndpointsRuleEngineTests.swift
Show resolved
Hide resolved
DmitriyMusatkin
approved these changes
Oct 14, 2022
waahm7
approved these changes
Oct 16, 2022
DmitriyMusatkin
approved these changes
Oct 27, 2022
Merged
waahm7
added a commit
that referenced
this pull request
Dec 6, 2022
This reverts commit d9f6ae3. # Conflicts: # aws-common-runtime/aws-c-sdkutils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
awslabs/aws-sdk-swift#624
Description of changes:
CRT implements the rule set evaluation system and this change creates bindings for Swift SDK. The usage of API is quite straight forward which is 1:1 of C APIs
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.