Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bindings for EndpointsRuleEngine #79

Merged
merged 33 commits into from
Oct 27, 2022
Merged

Conversation

ganeshnj
Copy link
Contributor

@ganeshnj ganeshnj commented Oct 5, 2022

Issue #, if available:
awslabs/aws-sdk-swift#624

Description of changes:

CRT implements the rule set evaluation system and this change creates bindings for Swift SDK. The usage of API is quite straight forward which is 1:1 of C APIs

// engine must be initialized with a rule set string
let engine = try CRTAWSEndpointsRuleEngine(partitions: partitions, ruleSet: ruleSet)

// populate context with available params
let context = try CRTAWSEndpointsRequestContext()
try context.add(name: "Region", value: "us-west-2")

// resolve
let endpoint = try engine.resolve(context: context)
let url = try endpoint?.getURL()

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ganeshnj ganeshnj requested a review from jbelkins October 7, 2022 21:25
Base automatically changed from update-crt to main October 7, 2022 22:13
@ganeshnj ganeshnj force-pushed the jangirg/feat/endpoints-2-crt branch from 5388a97 to 5718103 Compare October 10, 2022 20:07
Comment on lines 20 to -26
- uses: actions/checkout@v1
- name: GitHub Action for SwiftLint
uses: norio-nomura/action-swiftlint@3.1.0
- name: GitHub Action for SwiftLint with --strict
uses: norio-nomura/action-swiftlint@3.1.0
with:
args: --strict
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strict is ignoring the .swiftlint config file and redundant to the line 20 after removing strict.

@ganeshnj ganeshnj merged commit d9f6ae3 into main Oct 27, 2022
@ganeshnj ganeshnj deleted the jangirg/feat/endpoints-2-crt branch October 27, 2022 19:22
@waahm7 waahm7 mentioned this pull request Nov 22, 2022
waahm7 added a commit that referenced this pull request Dec 6, 2022
This reverts commit d9f6ae3.

# Conflicts:
#	aws-common-runtime/aws-c-sdkutils
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants