feat: implement DefaultEndpointResolver using CRT #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganeshnj
force-pushed
the
jangirg/feat/endpoints-2
branch
from
f039f3e to
d801431
Compare
added 4 commits
October 7, 2022 16:21
this will never happen in final models
ganeshnj
force-pushed
the
jangirg/feat/endpoints-2-crt
branch
from
5757f14 to
d9c4cce
Compare
ganeshnj
force-pushed
the
jangirg/feat/endpoints-2
branch
from
d801431 to
fa1c4a3
Compare
added 2 commits
October 11, 2022 13:51
jbelkins
approved these changes
Oct 13, 2022
| writer.write("self.endpointResolver = endpointResolver") | ||
| } | ||
| writer.indent().write("self.${it.memberName} = try \$L()", AWSServiceTypes.DefaultEndpointResolver) | ||
| writer.dedent().write("}") |
There was a problem hiding this comment.
No need to address it here, but using indent then dedent is an awkward, potentially error-prone way of writing an if-else statement... wonder if there should be a method on writer for a two-block statement
… for cross platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
#624
Description of changes
This changes takes awslabs/aws-crt-swift#79 Swift bindings and create wrappers for it in AWS Client Runtime. These wrappers are used in the service code which is codegen.
New/existing dependencies impact assessment, if applicable
No new dependencies were added to this change.
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.