fix: Make operations correctly model service errors #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 1, 2023 18:49
…izers for operation errors are being made.
2 tasks
jbelkins
requested changes
Sep 8, 2023
...ithy/aws/swift/codegen/ec2query/httpResponse/AWSEc2QueryHttpResponseBindingErrorGenerator.kt
Outdated
Show resolved
Hide resolved
...software/amazon/smithy/aws/swift/codegen/awsjson/AWSJsonHttpResponseBindingErrorGenerator.kt
Outdated
Show resolved
Hide resolved
…g for all changed protocols.
dayaffe
requested changes
Sep 11, 2023
...software/amazon/smithy/aws/swift/codegen/awsjson/AWSJsonHttpResponseBindingErrorGenerator.kt
Outdated
Show resolved
Hide resolved
...software/amazon/smithy/aws/swift/codegen/awsjson/AWSJsonHttpResponseBindingErrorGenerator.kt
Outdated
Show resolved
Hide resolved
...software/amazon/smithy/aws/swift/codegen/awsjson/AWSJsonHttpResponseBindingErrorGenerator.kt
Outdated
Show resolved
Hide resolved
...smithy/aws/swift/codegen/awsrestjson/AWSRestJson1HttpResponseBindingErrorGeneratableTests.kt
Outdated
Show resolved
Hide resolved
dayaffe
reviewed
Sep 11, 2023
...software/amazon/smithy/aws/swift/codegen/awsjson/AWSJsonHttpResponseBindingErrorGenerator.kt
Outdated
Show resolved
Hide resolved
dayaffe
reviewed
Sep 11, 2023
...ithy/aws/swift/codegen/ec2query/httpResponse/AWSEc2QueryHttpResponseBindingErrorGenerator.kt
Outdated
Show resolved
Hide resolved
dayaffe
reviewed
Sep 11, 2023
...ithy/aws/swift/codegen/ec2query/httpResponse/AWSEc2QueryHttpResponseBindingErrorGenerator.kt
Outdated
Show resolved
Hide resolved
sichanyoo
force-pushed
the
fix/make-operations-model-service-errors
branch
from
b02fc8c to
c29dd2e
Compare
dayaffe
reviewed
Sep 12, 2023
...software/amazon/smithy/aws/swift/codegen/awsjson/AWSJsonHttpResponseBindingErrorGenerator.kt
Outdated
Show resolved
Hide resolved
dayaffe
reviewed
Sep 12, 2023
...ithy/aws/swift/codegen/ec2query/httpResponse/AWSEc2QueryHttpResponseBindingErrorGenerator.kt
Outdated
Show resolved
Hide resolved
dayaffe
requested changes
Sep 12, 2023
sichanyoo
force-pushed
the
fix/make-operations-model-service-errors
branch
from
0db429e to
c29dd2e
Compare
sichanyoo
force-pushed
the
fix/make-operations-model-service-errors
branch
from
f476175 to
ffd60cc
Compare
jbelkins
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Addresses the Issue #1080
Description of changes
Adds code generation for a helper method
makeServicethat handles service errors to AWS protocols.Corresponding PR in
smithy-swift: smithy-lang/smithy-swift#581Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.