fix: Make operations correctly model service errors #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sichanyoo
changed the title
sichanyoo
changed the title
dayaffe
requested changes
Aug 30, 2023
...main/kotlin/software/amazon/smithy/swift/codegen/model/FlattenServiceErrorsOntoOperations.kt
Outdated
Show resolved
Hide resolved
jbelkins
requested changes
Aug 31, 2023
smithy-swift-codegen/src/main/kotlin/software/amazon/smithy/swift/codegen/CodegenVisitor.kt
Outdated
Show resolved
Hide resolved
added 2 commits
September 1, 2023 18:50
…izers for operation errors are being made.
…or service errors.
2 tasks
jbelkins
reviewed
Sep 8, 2023
...main/kotlin/software/amazon/smithy/swift/codegen/integration/HttpBindingProtocolGenerator.kt
Outdated
Show resolved
Hide resolved
...otlin/software/amazon/smithy/swift/codegen/integration/httpResponse/HttpResponseGenerator.kt
Show resolved
Hide resolved
dayaffe
requested changes
Sep 11, 2023
...main/kotlin/software/amazon/smithy/swift/codegen/integration/HttpBindingProtocolGenerator.kt
Outdated
Show resolved
Hide resolved
...main/kotlin/software/amazon/smithy/swift/codegen/integration/HttpBindingProtocolGenerator.kt
Outdated
Show resolved
Hide resolved
...otlin/software/amazon/smithy/swift/codegen/integration/httpResponse/HttpResponseGenerator.kt
Outdated
Show resolved
Hide resolved
smithy-swift-codegen/src/test/kotlin/mocks/MockHttpResponseBindingErrorGenerator.kt
Outdated
Show resolved
Hide resolved
added 2 commits
September 11, 2023 14:36
dayaffe
approved these changes
Sep 11, 2023
sichanyoo
force-pushed
the
fix/make-operations-model-service-errors
branch
from
fd20b70 to
1147526
Compare
jbelkins
requested changes
Sep 12, 2023
There was a problem hiding this comment.
In the case where there are no modeled errors on the service, we should omit the method for topLevelServiceErrorMembers and the calls to it.
This is consistent with elsewhere in codegen, where components are omitted where they are an empty set or otherwise serve no function.
sichanyoo
force-pushed
the
fix/make-operations-model-service-errors
branch
from
bd7198d to
530ea94
Compare
jbelkins
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Addresses the Issue #1080
Description of changes
Adds service errors into pre-existing code-generation flow for error initializers and error deserializers
Corresponding PR in
aws-sdk-swift: awslabs/aws-sdk-swift#1114Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.