-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for eventstream input & initial request to RPC-based protocols #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sichanyoo
temporarily deployed
to
Integration-Test
March 4, 2024 21:54 — with
GitHub Actions
Inactive
sichanyoo
had a problem deploying
to
Codegen-Build-Test
March 4, 2024 21:54 — with
GitHub Actions
Failure
sichanyoo
temporarily deployed
to
Integration-Test
March 4, 2024 21:55 — with
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
March 4, 2024 21:55 — with
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
March 4, 2024 21:55 — with
GitHub Actions
Inactive
2 tasks
sichanyoo
had a problem deploying
to
Codegen-Build-Test
March 4, 2024 22:02 — with
GitHub Actions
Failure
sichanyoo
temporarily deployed
to
Integration-Test
March 4, 2024 22:02 — with
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
March 4, 2024 22:02 — with
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
March 4, 2024 22:02 — with
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
March 4, 2024 22:03 — with
GitHub Actions
Inactive
…hapes in extension when: 1) protocol uses RPC architecture 2) protocol supports event streaming 3) input shape at hand has streaming union member. The generated method returns EventStream.Message from the input struct, with non-sreaming members encoded into payload & :event-type: initial-request header in its headers.
…n for generating encodable conformances, like restJson1 does.
…/ add codegen tests for event stream input and iniital request for awsJson protocol codegen.
sichanyoo
had a problem deploying
to
Codegen-Build-Test
March 8, 2024 00:37 — with
GitHub Actions
Failure
sichanyoo
had a problem deploying
to
Integration-Test
March 8, 2024 00:37 — with
GitHub Actions
Failure
sichanyoo
had a problem deploying
to
Integration-Test
March 8, 2024 00:37 — with
GitHub Actions
Failure
sichanyoo
had a problem deploying
to
Integration-Test
March 8, 2024 00:37 — with
GitHub Actions
Failure
sichanyoo
had a problem deploying
to
Integration-Test
March 8, 2024 00:37 — with
GitHub Actions
Failure
sichanyoo
had a problem deploying
to
Codegen-Build-Test
March 8, 2024 00:56 — with
GitHub Actions
Failure
sichanyoo
temporarily deployed
to
Integration-Test
March 8, 2024 00:56 — with
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
March 8, 2024 00:56 — with
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
March 8, 2024 00:56 — with
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
March 8, 2024 00:56 — with
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
March 8, 2024 01:23 — with
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Codegen-Build-Test
March 8, 2024 01:23 — with
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
March 8, 2024 01:23 — with
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
March 8, 2024 01:23 — with
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
March 8, 2024 01:23 — with
GitHub Actions
Inactive
…quest method to smithy-swift. Rename package in integrations list to use the new package location.
sichanyoo
temporarily deployed
to
Integration-Test
March 13, 2024 21:45 — with
GitHub Actions
Inactive
sichanyoo
had a problem deploying
to
Codegen-Build-Test
March 13, 2024 21:45 — with
GitHub Actions
Failure
sichanyoo
temporarily deployed
to
Integration-Test
March 13, 2024 21:45 — with
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
March 13, 2024 21:45 — with
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
March 13, 2024 21:45 — with
GitHub Actions
Inactive
jbelkins
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Companion PR: smithy-lang/smithy-swift#675
For RPC-based protocols:
Eventstream input ticket: #1175
Initial request ticket: #1172
Description of changes
New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.