feat: Add support for eventstream input & initial request to RPC-based protocols #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 4, 2024 13:38
…PC-based protocols to runtime & codegen.
added 5 commits
March 6, 2024 12:42
…time library be passed in EventStream.Message for an initial request. Necessary changes in codegen that constructs this initial request Message then passes it into EventStreamBodyMiddleware via consturctor is upcoming.
…ddleare constructor codegen. Condition is whether the protocol is an RPC protocl that supports event streaming (awsJson1_0 or awsJson1_1).
…itialRequest to initialRequestMessage & add calling code for getting initial request message from the input struct.
…col is RPC 2) protocol supports event streaming. Exclude streaming union member from this. This encodable conformance is used to serialize the input struct to initial request message.
jbelkins
reviewed
Mar 13, 2024
| private fun addEventStreamMiddleware(writer: SwiftWriter, operationStackName: String, inputSymbol: Symbol, outputSymbol: Symbol, payloadSymbol: Symbol, keyPath: String, defaultBody: String) { | ||
| private fun addEventStreamMiddleware(writer: SwiftWriter, operationStackName: String, inputSymbol: Symbol, outputSymbol: Symbol, payloadSymbol: Symbol, keyPath: String, defaultBody: String, sendInitialRequest: Boolean) { | ||
| if (sendInitialRequest) { | ||
| writer.write("let initialRequestMessage = try input.makeInitialRequestMessage(encoder: encoder)") |
There was a problem hiding this comment.
Does makeInitialRequestMessage(encoder: encoder) get generated somewhere?
There was a problem hiding this comment.
Moved the codegen for this method from aws-sdk-swift to smithy-swift as pointed out in offline discussion, given initial request is part of the generic Smithy specification.
| // marshall event to message | ||
| let message = try event.marshall(encoder: requestEncoder) | ||
|
|
||
| let message = try event.marshall(encoder: requestEncoder) |
There was a problem hiding this comment.
nit: 2 spaces between let & message
jbelkins
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Companion PR: awslabs/aws-sdk-swift#1377
For RPC-based protocols:
Eventstream input ticket: awslabs/aws-sdk-swift#1175
Initial request ticket: awslabs/aws-sdk-swift#1172
Description of changes
func makeInitialRequestMessagein extension of input structs when: 1) protocol is RPC, 2) protocol supports event streaming, 3) upstream input shape has streaming union member.EventStreamBodyMiddlewarecodegen for RPC protocols that support event streaming.EventStreamBodyMiddlewaretake ininitialRequestMessagein constructor. The middleware passes this value toDefaultMessageEncoderStreamconstructor.DefaultMessageEncoderStreamreturninitialRequestMessageas the first item in stream if it is non-nil and was set during construction.Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.