feat: update GenerationContext with directed codegen related changes #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewFossAWS
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
This was referenced Mar 27, 2024
syall
suggested changes
Mar 27, 2024
There was a problem hiding this comment.
When checking out this PR with the changes in smithy-lang/smithy-swift#681 and running ./scripts/codegen.sh, there are unaccounted codegen diffs: https://gist.github.com/syall/b3be467594818c89b19bc477b0627e89
Besides the no-ops of code just moving around, some of the error structures are missing the CustomDebugStringConvertibleGenerator extension (e.g. this ValidationException).
I think this is because DirectedSwiftCodegen visits errors explicitly, but CodegenVisitor treated errors as normal structures. See the PR comment for a possible fix: smithy-lang/smithy-swift#681 (comment)
The CI is also failing, unsure why.
2 tasks
syall
approved these changes
Mar 27, 2024
sichanyoo
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.