feat: add directed codegen #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewFossAWS
force-pushed
the
dcg
branch
2 times, most recently
from
a698e45 to
4ab9ea1
Compare
This was referenced Mar 27, 2024
syall
suggested changes
Mar 27, 2024
|
|
||
| class DirectedSwiftCodegen(val context: PluginContext) : | ||
| DirectedCodegen<GenerationContext, SwiftSettings, SwiftIntegration> { | ||
| private val LOGGER = Logger.getLogger(javaClass.name) |
There was a problem hiding this comment.
nit: is there a Kotlin logging library we should be using instead of the Java one?
There was a problem hiding this comment.
I don't think there is an "official" kotlin logging library so I am using the Java one for now. Can add it later if needed to.
smithy-swift-codegen/src/main/kotlin/software/amazon/smithy/swift/codegen/ImportDeclarations.kt
Outdated
Show resolved
Hide resolved
...hy-swift-codegen/src/main/kotlin/software/amazon/smithy/swift/codegen/core/CodegenContext.kt
Outdated
Show resolved
Hide resolved
smithy-swift-codegen/src/main/kotlin/software/amazon/smithy/swift/codegen/CodegenVisitor.kt
Outdated
Show resolved
Hide resolved
syall
suggested changes
Mar 27, 2024
...y-swift-codegen/src/main/kotlin/software/amazon/smithy/swift/codegen/DirectedSwiftCodegen.kt
Show resolved
Hide resolved
sichanyoo
requested changes
Mar 27, 2024
...codegen/src/main/kotlin/software/amazon/smithy/swift/codegen/integration/SwiftIntegration.kt
Show resolved
Hide resolved
Comment on lines
+289
to
+277
| putFormatter('D', SwiftSymbolFormatter(shouldSetDefault = true, shouldRenderOptional = true)) | ||
| putFormatter('T', SwiftSymbolFormatter(shouldSetDefault = false, shouldRenderOptional = true)) | ||
| putFormatter('N', SwiftSymbolFormatter(shouldSetDefault = false, shouldRenderOptional = false)) |
There was a problem hiding this comment.
What are the usecases for these formatters? Could comments be added here for quick reference?
syall
approved these changes
Mar 27, 2024
...y-swift-codegen/src/main/kotlin/software/amazon/smithy/swift/codegen/SwiftImportContainer.kt
Outdated
Show resolved
Hide resolved
…emove CodegenVisitor and add missing CustomDebugStringConvertibleGenerator to directed codegen
sichanyoo
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.