Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump kotlin version to 1.9.24 #1487

Merged
merged 1 commit into from
May 8, 2024
Merged

feat: bump kotlin version to 1.9.24 #1487

merged 1 commit into from
May 8, 2024

Conversation

syall
Copy link
Contributor

@syall syall commented May 7, 2024

Issue #

There were a lot of noisy logs from Gradle / Kotlin, e.g.

java.rmi.ServerError: Error occurred in server thread; nested exception is: 
Could not connect to kotlin daemon. Using fallback strategy.
	java.lang.AssertionError: symbolic reference class is not accessible: class sun.nio.ch.FileChannelImpl, from class org.jetbrains.kotlin.com.intellij.util.io.FileChannelUtil (unnamed module @46805db7)
...

This PR should fix all of the noise (at least locally).

See related links:

Description of changes

Corresponding smithy-swift PR: smithy-lang/smithy-swift#717

Bump kotlin version to 1.9.24

Also:

  • bump dokka version to 1.9.20
  • target JVM 17 output

New/existing dependencies impact assessment, if applicable

Kotlin and Dokka versions updated to the latest version, and JVM 17 targeted.

Conventional Commits

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@syall syall marked this pull request as draft May 7, 2024 22:52
@syall syall marked this pull request as ready for review May 7, 2024 23:07
@syall syall force-pushed the upgrade-kotlin-stdlib branch from f1f391f to 46d7993 Compare May 7, 2024 23:12
@syall
Copy link
Contributor Author

syall commented May 7, 2024

Looks like CI still has noisy log, but at locally they are gone.

> Task :smithy-swift:buildSrc:compileKotlin
Compilation with Kotlin compile daemon was not successful
java.rmi.ServerError: Error occurred in server thread; nested exception is: 
	java.lang.AssertionError: symbolic reference class is not accessible: class sun.nio.ch.FileChannelImpl, from class org.jetbrains.kotlin.com.intellij.util.io.FileChannelUtil (unnamed module @46805db7)
	at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:389)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197)

My guess is that it could be the gradle version, but unsure.

@syall syall force-pushed the upgrade-kotlin-stdlib branch from 46d7993 to e52c977 Compare May 8, 2024 15:50
@jbelkins jbelkins self-requested a review May 8, 2024 15:54
Also:

- bump dokka version to 1.9.20
- target JVM 17 output
@syall syall force-pushed the upgrade-kotlin-stdlib branch from e52c977 to 53cd8aa Compare May 8, 2024 16:22
@jbelkins jbelkins merged commit 939b261 into main May 8, 2024
29 checks passed
@jbelkins jbelkins deleted the upgrade-kotlin-stdlib branch May 8, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants