feat: bump kotlin version to 1.9.24 #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syall
force-pushed
the
upgrade-kotlin-stdlib
branch
from
f3c455e to
9c1cf6f
Compare
syall
commented
May 7, 2024
Comment on lines
+31
to
+34
| - name: Clean and Build | ||
| run: ./gradlew clean build -Plog-tests |
There was a problem hiding this comment.
Looks like the noisy logs are still present in CI, though locally they are gone, e.g.
> Task :buildSrc:compileKotlin
java.rmi.ServerError: Error occurred in server thread; nested exception is:
Could not connect to kotlin daemon. Using fallback strategy.
java.lang.AssertionError: symbolic reference class is not accessible: class sun.nio.ch.FileChannelImpl, from class org.jetbrains.kotlin.com.intellij.util.io.FileChannelUtil (unnamed module @46805db7)
at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:389)
at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200)
at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197)
My guess is that it could be the gradle version, but unsure.
syall
force-pushed
the
upgrade-kotlin-stdlib
branch
from
9c1cf6f to
4ecc637
Compare
Also: - bump dokka version to 1.9.20 - target JVM 17 output - Add Codegen CI workflow
syall
force-pushed
the
upgrade-kotlin-stdlib
branch
from
4ecc637 to
fd278ba
Compare
jbelkins
approved these changes
May 8, 2024
AndrewFossAWS
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
There were a lot of noisy logs from Gradle / Kotlin, e.g.
This PR should fix all of the noise (at least locally).
See related links:
Description of changes
Corresponding AWS SDK Swift PR: awslabs/aws-sdk-swift#1487
Bump kotlin version to 1.9.24
Also:
Kotlin and Dokka versions updated to the latest version, and JVM 17 targeted.
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.