feat: Add deprecated shape remover #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sichanyoo
changed the title
2 tasks
jbelkins
reviewed
May 20, 2024
| val contents = TestUtils.getModelFileContents("Example", "OperationWithDeprecatedInputMembersInput.swift", context.manifest) | ||
| contents.shouldSyntacticSanityCheck() | ||
| val removedContent = """ | ||
| @available(*, deprecated, message: " API deprecated since 2024-09-01") |
There was a problem hiding this comment.
Why is there a leading space in the message? Even if not part of this PR, we should remove that
There was a problem hiding this comment.
Good catch; fixed as part of smithy-lang/smithy-swift#732.
jbelkins
approved these changes
May 20, 2024
added 2 commits
May 20, 2024 10:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
#1026
Description of changes
sinceproperty if earlier than cutoff date.New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.