Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Misc codegen fixes #732

Merged
merged 2 commits into from
May 20, 2024
Merged

chore: Misc codegen fixes #732

merged 2 commits into from
May 20, 2024

Conversation

sichanyoo
Copy link
Contributor

@sichanyoo sichanyoo commented May 20, 2024 •
edited
Loading

Issue #

Description of changes

  • Explicitly order errors alphabetically in generated comments
  • Handle unconditional extra spacing in deprecated shape message to be added conditionally

Scope

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sichanyoo sichanyoo changed the title chore: Explicitly order errors alphabetically in generated comments chore: Misc codegen fixes May 20, 2024
@sichanyoo sichanyoo merged commit dc64724 into main May 20, 2024
17 checks passed
@sichanyoo sichanyoo deleted the chore/sort-error-in-comments branch May 20, 2024 17:09
@sichanyoo sichanyoo mentioned this pull request May 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbelkins jbelkins jbelkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sichanyoo @jbelkins