feat!: Modularize identity and auth #1544
Conversation
| @@ -17,16 +17,22 @@ import PackageDescription | |||
|
|
|||
There was a problem hiding this comment.
Added AWSSDKCommon module that has FileBasedConfiguration. FileBasedConfiguration was previously located under AWSClientRuntime, but was moved because identity resolvers in AWSSDKIdentity require it AND region providers in AWSClientRuntime require it. After all modularization tasks are done, we'll decide what to do with AWSSDKCommon & stragglers in AWSClientRuntime.
| @@ -9,6 +9,7 @@ import Foundation | |||
| import XCTest | |||
There was a problem hiding this comment.
New import statements were added following new organization. No additional comments will be written for this type of change.
| @@ -1,32 +0,0 @@ | |||
| // | |||
There was a problem hiding this comment.
This was moved to smithy-swift.
| @@ -5,34 +5,53 @@ | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
There was a problem hiding this comment.
Some granular imports for easily seeing what's coming from what
| @@ -1,28 +0,0 @@ | |||
| // | |||
There was a problem hiding this comment.
This, along with next 3 files, are moved to smithy-swift.
| @@ -1,19 +0,0 @@ | |||
| // | |||
There was a problem hiding this comment.
This, along with next 6 files, are moved to smithy-swift.
| @@ -1,28 +0,0 @@ | |||
| // | |||
There was a problem hiding this comment.
This and the next file are moved to smithy-swift.
| @@ -1,11 +0,0 @@ | |||
| // | |||
There was a problem hiding this comment.
This is moved to smithy-swift.
| @@ -1,24 +0,0 @@ | |||
| // | |||
There was a problem hiding this comment.
This and next test files are moved to smithy-swift.
| @@ -89,7 +89,7 @@ extension ExampleClient { | |||
|
|
|||
There was a problem hiding this comment.
Codegen test updated to reflect new module.
sichanyoo
force-pushed
the
feat/modularize-identity-and-auth
branch
2 times, most recently
from
1ad0692
to
0f63cd5
Compare
| import class SmithyHTTPAPI.SdkHttpRequestBuilder | ||
| import enum AwsCommonRuntimeKit.CommonRunTimeError | ||
| import enum Smithy.ClientError | ||
| import enum SmithyChecksumsAPI.ChecksumAlgorithm |
There was a problem hiding this comment.
Merge conflict was not resolved properly as this was added back as a dependency
There was a problem hiding this comment.
Great catch, removed the import statement.
| $0.name == "AWSClientRuntimeTests" || | ||
| $0.name == "AWSSDKHTTPAuthTests" || | ||
| $0.name == "AWSSDKEventStreamsAuthTests" || | ||
| $0.name == "AWSSDKIdentityTests" |
Companion PR: smithy-lang/smithy-swift#751
Issue #
#1382
#1383
Description of changes
Modularize identity & auth according to SRA.
New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.