feat!: Modularize identity and auth #751
Conversation
| @@ -36,8 +36,10 @@ let package = Package( | |||
| .library(name: "SmithyXML", targets: ["SmithyXML"]), | |||
There was a problem hiding this comment.
Added 2 new modules: SmithyIdentity and SmithyHTTPAuth.
SmithyIdentity has concrete implementation of the Identity protocol from SmithyIdentityAPI module, such as AWSCredentialIdentity. It also has non-AWS specific AWS credential identity resolver such as StaticAWSCredentialIdentityResolver.
SmithyHTTPAuth has SigV4 signing config things moved from aws-sdk-swift. Moving the actual SigV4Signer and the auth schemes (e.g., SigV4AuthScheme) is on-hold for after HTTP modularization.
| @@ -12,6 +12,7 @@ import class Smithy.Context | |||
| import class SmithyHTTPAPI.SdkHttpRequestBuilder | |||
There was a problem hiding this comment.
Import statements have been made granular & updated to match new organization. No further comments will be made for this type of change.
| @@ -1,21 +0,0 @@ | |||
| // | |||
There was a problem hiding this comment.
This is moved to SmithyHTTPAuth module.
| @@ -0,0 +1,61 @@ | |||
| // | |||
There was a problem hiding this comment.
This was moved from aws-sdk-swift.
| @@ -0,0 +1,103 @@ | |||
| // | |||
There was a problem hiding this comment.
These are all adapter methods that convert types in SmithyHTTPAuthAPI to matching CRT types.
| @@ -1,9 +0,0 @@ | |||
| // | |||
There was a problem hiding this comment.
This is moved to Sources/SmithyIdentity/AWSCredentialIdentityResolver.swift, but git picked it up as deletion because the new file has new changes.
| @@ -0,0 +1,26 @@ | |||
| // | |||
There was a problem hiding this comment.
Organized into Context/ subdirectory along with other Context+XYZ files.
| @@ -0,0 +1,11 @@ | |||
| // | |||
There was a problem hiding this comment.
This was moved from aws-sdk-swift to here.
| @@ -0,0 +1,20 @@ | |||
| // | |||
There was a problem hiding this comment.
This test was moved from aws-sdk-swift to here, as the thing it's testing was moved as well.
| @@ -0,0 +1,22 @@ | |||
| // | |||
There was a problem hiding this comment.
This test was moved from aws-sdk-swift to here, as the thing it tests was moved here.
sichanyoo
force-pushed
the
feat/modularize-identity-and-auth
branch
from
83ad11a
to
b5c8100
Compare
sichanyoo
force-pushed
the
feat/modularize-identity-and-auth
branch
2 times, most recently
from
60a6fbb
to
328c8df
Compare
Package.swift
Outdated
| .target( | ||
| name: "SmithyHTTPAuthAPI", | ||
| dependencies: ["Smithy", "SmithyHTTPAPI"] | ||
| dependencies: ["Smithy", "SmithyHTTPAPI", "SmithyIdentityAPI", "SmithyChecksumsAPI"] |
There was a problem hiding this comment.
SmithyChecksumsAPI shouldnt be a dependency here
There was a problem hiding this comment.
Removed as pointed out
| // SPDX-License-Identifier: Apache-2.0 | ||
| // | ||
|
|
||
| import enum SmithyChecksumsAPI.ChecksumAlgorithm |
There was a problem hiding this comment.
This should be a string / have no dependency on checksums
There was a problem hiding this comment.
Removed as pointed out
Companion PR: awslabs/aws-sdk-swift#1544
Issue #
awslabs/aws-sdk-swift#1382
awslabs/aws-sdk-swift#1383
Description of changes
Modularize identity & auth according to SRA.
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.