This repository has been archived by the owner on Dec 6, 2024. It is now read-only.
fix: add coverage for undef config case #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maghirardelli
requested review from
nguyen102,
Bingjiling,
SanketD92 and
jn1119
Codecov Report
@@ Coverage Diff @@
## develop #761 +/- ##
========================================
Coverage 52.09% 52.09%
========================================
Files 272 272
Lines 14519 14519
Branches 2285 2285
========================================
Hits 7563 7563
Misses 6106 6106
Partials 850 850 Continue to review full report at Codecov.
|
SanketD92
reviewed
Oct 18, 2021
...-raas-ui/packages/base-raas-ui/src/parts/environments-sc/__tests__/ScEnvironmentCard.test.js
Outdated
Show resolved
Hide resolved
SanketD92
reviewed
Oct 18, 2021
...-raas-ui/packages/base-raas-ui/src/parts/environments-sc/__tests__/ScEnvironmentCard.test.js
Outdated
Show resolved
Hide resolved
SanketD92
reviewed
Oct 18, 2021
...-raas-ui/packages/base-raas-ui/src/parts/environments-sc/__tests__/ScEnvironmentCard.test.js
Outdated
Show resolved
Hide resolved
SanketD92
reviewed
Oct 18, 2021
...-raas-ui/packages/base-raas-ui/src/parts/environments-sc/__tests__/ScEnvironmentCard.test.js
Outdated
Show resolved
Hide resolved
…service-workbench-on-aws into undef-config-unit-tests
SanketD92
approved these changes
Oct 18, 2021
jxuamazon
pushed a commit
to jxuamazon/service-workbench-on-aws
that referenced
this pull request
Feb 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: add unit tests for bug fix of undefined configuration in sc environment card
Checklist:
AS review ticket id:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.