Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.0.0 release date? #262

Closed
alekseykulikov opened this issue Oct 10, 2016 · 10 comments
Closed

Version 3.0.0 release date? #262

alekseykulikov opened this issue Oct 10, 2016 · 10 comments
Assignees
Labels
Milestone

Comments

@alekseykulikov
Copy link

List of changes is really impressive and I would like to try it! Maybe RC for testing?

@brettz9
Copy link
Collaborator

brettz9 commented Oct 10, 2016

See pars. 3-5 of #259 (comment) .

An RC is a good idea. For now master can be tested and should be working with Node too. Any help testing would indeed be most appreciated!

@brettz9
Copy link
Collaborator

brettz9 commented Oct 18, 2016

FYI, my personal idea about a 3.0.0 release would be for the following additional items:

@brettz9
Copy link
Collaborator

brettz9 commented Apr 16, 2017

As mentioned at #249 , we are really ready now for specific browser testing. While I have not gotten all of the issues resolved that I intended, I think it is good enough for a release candidate, especially if people will help get the remaining Chrome/Safari issues not present in Node passing (which should be easier now that the W3C browser testing can be run against our polyfill with single tests and, where it works like in Chrome, in bulk testing).

If this is ok with you, @axemclion , and if we hear interest in helping with W3C browser bug fixing, @alekseykulikov , etc., I think we're ready.

But bear in mind that my work was mostly geared for Node.js support; the browser should also work when the full shim is applied, but there are currently failures in the browser that do not occur in Node; those interested in getting browser support applied to the new (breaking) release ought to help out. Please also see #277 for an issue in particular need of consideration, what to do about the code rot for iOS9/non-Chrome Android IE and whether anyone can bring it up to date or whether we should remove it or what not...

@tarjei
Copy link

tarjei commented Apr 20, 2017

Thanks!

@brettz9
Copy link
Collaborator

brettz9 commented Apr 21, 2017

I recommend that, unless some volunteers available to carry it along (#277), we abandon iOS9 support for version 3.0.0 (which would be a breaking release anyways). The polyfilling was apparently for IE rather than iOS9, so the IE plugging is what is being dropped (all or nothing). Whatever value there is left in shimming the likes of modern Chrome and Safari 10, there is, I think, definite utility in getting out a Node package now (and btw, I just pushed a few more fixes to master, leaving us with just a handful of W3C tests that are failing or not running).

Alternatively, especially if I don't hear back from @axemclion who I guess may be too busy to even consider the issue at the moment, I might just publish a Node-supporting fork under a separate name. But if I do this, I wouldn't recommend that this current repository be reverted because there are so many fixes that if someone did want to update the polyfill to work with iOS9 the browsers that used it (IE apparently), they really should start with this base, imo (and there is already the prior npm releases which can continue to be used).

Thoughts?

@brettz9
Copy link
Collaborator

brettz9 commented May 3, 2017

Ok, so I've made a branch (though I plan to keep rebasing it until release) for 3.0.0. As planned, I've removed the polyfill (though it was apparently targeted instead to IE's (then?) incomplete implementation rather than iOS), so upon release, it will now be limited to all-or-nothing--polyfill everything or nothing though get Node support and better all-around compliance.

I think I'll wait on the completion of PR #301 , but otherwise, I plan to publish a RC shortly, either within the current npm package if @BigstickCarpet replies to give access or in a new npm package otherwise.

@brettz9
Copy link
Collaborator

brettz9 commented May 3, 2017

Ok, finally we have a release candidate--3.0.0-rc.1 is published to npm and released as a tag for Bower!

I guess I'll keep the issue open until the final release version, but I've pushed anything remaining to milestone 3.1.0.

No doubts lots that can be done, even beyond that already envisioned. Look forward to hearing how it's working for ya or if y'all end up using it in interesting ways...

@brettz9
Copy link
Collaborator

brettz9 commented May 3, 2017

Sorry for the comment spam, but realized I did need to adjust the key sorting for better future-compatibility after all.. Now released as RC 2...

@brettz9
Copy link
Collaborator

brettz9 commented May 5, 2017

On RC 6 now. I've updated the version 3 to-do list to take into account that the goals are either completed, or a few migrated to milestone 3.1.0.

Really hope we get some folks testing now so that our 3.0.0 release is well-tested.

@brettz9
Copy link
Collaborator

brettz9 commented May 29, 2017

Ok, just pushed out 3.0.0. Thanks to those who assisted with bug reports, etc.!

@brettz9 brettz9 closed this as completed May 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants