Allow overriding compression levels with environment variables #212
Conversation
This introduces three environment variables, with the following defaults: * `AXOASSET_GZ_LEVEL=6` * `AXOASSET_XZ_LEVEL=9` * `AXOASSET_ZSTD_LEVEL=3` (The defaults are unchanged, but when we iterate on dist builds using dist itself, exporting `AXOASSET_XZ_LEVEL=1` will make it go faster — it is _genuinely_ the blocker on warm builds lol)
fasterthanlime
requested review from
mistydemeo,
duckinator and
ashleygwilliams
| std::env::var("AXOASSET_GZ_LEVEL") | ||
| .ok() | ||
| .and_then(|val| val.parse().ok()) | ||
| .unwrap_or(6) |
There was a problem hiding this comment.
i am trusting you that the default values are good- it may be useful to comment why you picked those, but i wouldn't consider it a blocker
There was a problem hiding this comment.
6 seems like a good default - checking the gzip manpages, both BSD and GNU gzip default to 6. Agree that a comment would be great.
There was a problem hiding this comment.
So the numeric values you're seeing here is what axoasset currently does — it just wasn't visible in the code until now.
I followed the thread to find out what compression level it was actually applying, and.. the only default that jumps out to me is the .xz one, I think at 9 it's a little extreme.
However, changing the default would be user-facing so we need to talk about it, announce it in advance, provide cargo-dist config to tune it, etc. — all best left for follow-ups.
This introduces three environment variables, with the following defaults:
AXOASSET_GZ_LEVEL=6AXOASSET_XZ_LEVEL=9AXOASSET_ZSTD_LEVEL=3(The defaults are unchanged, but when we iterate on dist builds using dist itself, exporting
AXOASSET_XZ_LEVEL=1will make it go faster — it is genuinely the blocker on warm builds lol)