-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP cross-compilation support #1470
Conversation
8158df7
to
3a9c433
Compare
281e264
to
9d4601e
Compare
6df26dd
to
215c43d
Compare
To make this PR thinner, I'd love to get a ✅ on axodotdev/axoasset#212 (and then a cargo publish, and a bump on the version of axoasset that cargo-dist pulls in). I'd also love to get these merged separately:
The rest of the PR is pretty radioactive for now, it has a bunch of .unwrap(), I want to use My guess is that for now if |
This has been extracted out of #1470 and it's part of making a faster "edit-compile-test-in-ci" cycle when working on cross-compilation. The rationale is included as inline comments.
5fe6657
to
dde1c27
Compare
This has been extracted out of #1470 and it's part of making a faster "edit-compile-test-in-ci" cycle when working on cross-compilation. The rationale is included as inline comments.
Quick piece of insight I had while looking at: in the absence of other info, we can assume that the custom runners have the arch they're being used for. Since cargo-dist did not support cross when that config format was invented. Later, we can disallow doing something like: [dist.github-custom-runners]
aarch64-unknown-linux-gnu = "my-fast-runner"
x86_64-unknown-linux-gnu = "my-fast-runner" With something like "what's the target triple for github runner 'my-fast-runner'? tell us by doing this: [dist.github-custom-runner-specs]
my-fast-runner = { triple = "aarch64-unknown-linux-gnu" } ...or whatever makes sense to us. |
fdd571a
to
842a721
Compare
Closing in favor of #1529 |
No description provided.