feat(plugins): add Glance.nvim

[Jint-lzxy]

#494 (reply in thread)

[vollowx]

Maybe a better LSP functions redirecting implementation

---@diagnostic disable: duplicate-set-field
-- Override LSP handler functions
-- stylua: ignore start
vim.lsp.buf.references = function() glance.open('references') end
vim.lsp.buf.definition = function() glance.open('definitions') end
vim.lsp.buf.type_definition = function() glance.open('type_definitions') end
vim.lsp.buf.implementations = function() glance.open('implementations') end
-- stylua: ignore end
---@diagnostic enable: duplicate-set-field

[vollowx]

A little fix of appearance.

[vollowx]

Catppuccin use darker colors for higher layers.

theme = {
  mode = 'darken',
},

[Jint-lzxy]

But IMO it would be better to make this slightly brighter cause it would help distinguish the main window from other floating ones.

[fecet]

If the definition target are the current buffer, will glance destroy all keymap in the buffer? I fix lspsaga for this nvimdev/lspsaga.nvim#1188?

[vollowx]

If the definition target are the current buffer, will glance destroy all keymap in the buffer? I fix lspsaga for this nvimdev/lspsaga.nvim#1188?

I have used glance for weeks, and didn't meet this issue yet.

[fecet]

That will cause troulbe only in certain case, say you are using a repl should contact to your current buffer or you have some keymap conflict with it, like I set <CR> to do incremental selection and this was defined in peek_definition in lspsaga.

[ayamir]

One problem is that glance.nvim doesn't have the same ability on lsp goto definition.
I can't goto the definition place when it is defined in other files.
It should be the bug of glance.nvim b/c even the default lsp handler support this.

What's more, the way of overriding lsp handler breaks Lspsaga goto_definition defined in keymap/completion.lua.

[Jint-lzxy]

One problem is that glance.nvim doesn't have the same ability on lsp goto definition. I can't goto the definition place when it is defined in other files. It should be the bug of glance.nvim b/c even the default lsp handler support this.

What's more, the way of overriding lsp handler breaks `Lspsaga goto_definition` defined in `keymap/completion.lua`.

Ah sorry I forgot to mention this - I made this change intentionally. But after cfeea4f, indeed it's better to bring the original functionality back. Will push a fix for this.

[Jint-lzxy]

313b49a

[Jint-lzxy]

If the definition target are the current buffer, will glance destroy all keymap in the buffer?

@fecet I scanned the source code while setting up this plugin, and I don't think it's an issue b/c Glance works quite similarly to our utils.keymap module (i.e., "fixing", not "replacing" the keymap). To verify this, Q should echo out MSG before and after Glance gets opened.

:noremap <silent> <nowait> <buffer> Q <Cmd>echo 'MSG'<CR>

[fecet]

Great, I will test if it works will with my repl later

[fecet]

I originally thought we were going to use glance to replace the peek function of lspsaga, so my previous concerns were irrelevant. But why not?

[ayamir]

I originally thought we were going to use glance to replace the peek function of lspsaga, so my previous concerns were irrelevant. But why not?

Does it support definition preview?

[fecet]

Doesn't know now but I used glance to preview definition before switching to lspsaga

[Jint-lzxy]

I originally thought we were going to use glance to replace the peek function of lspsaga, so my previous concerns were irrelevant. But why not?

3aae05b

[fecet]

glance's gd works fine for me

[ayamir]

LGTM now

[aarnphm]

Works on my end

[CharlesChiuGit]

Works for me too.