feat(plugins): add `flash.nvim` to replace `clever-f.vim` #926

YuCao16 · 2023-08-02T15:50:58Z

In core/mapping.lua, I wrote a function for users who don't have flash.nvim installed.
I only bind partial keymap available in flash.nvim in keymap/editor.lua, because I use the default s quite often.

YuCao16 · 2023-08-02T15:54:24Z

I'm not sure If I should remove cleverf, because it involves delete&replace it's keymap. I hope maintainer could offer some help and advise.

Jint-lzxy · 2023-08-02T15:55:25Z

IMO we may need to do some other cleanups as several plugins will be deprecated due to this PR, and their keymaps should bind to this new integration.

YuCao16 · 2023-08-02T16:17:56Z

21748b2: remove clever-f should work, it's keymap seems equal to flash.nvim's default.

https://github.com/folke/flash.nvim/blob/967117690bd677cb7b6a87f0bc0077d2c0be3a27/lua/flash/plugins/char.lua#L117C1-L117C1

fecet · 2023-08-02T16:29:37Z

What's the reason to add this, it doesn't do more than hop and treehopper

YuCao16 · 2023-08-02T16:37:15Z

What's the reason to add this, it doesn't do more than hop and treehopper

You can check out it's README.md. In short, it combines all three plugins (include clever-f) and enhances /. Isn't it worth it? :D

Jint-lzxy · 2023-08-02T16:42:42Z

What's the reason to add this, it doesn't do more than hop and treehopper

After scanning through the introduction of this plugin, one of the most significant benefits that came to my mind was it integrates all motion commands together, which signifies a high probability of simplifying our code. But I haven't checked its implementation detail yet - ~~looks like according to #494 (reply in thread), it also has the common issue(s) of those 'highly-integrated' plugins - being too intrusive. If this is the case, IMO~~ we can change the purpose this PR to 'use lua alternatives for those vimscript plugins' (e.g., use leap.nvim and flit.nvim), which does a very similar thing.

YuCao16 · 2023-08-02T16:48:29Z

I agree, but I'm only using some of the basic features of comments.nvim. Can you explain how it conflicts with flash.nvim? Because it seems to me that I only defined S, and clever-f also defines f and F.

fecet · 2023-08-02T16:49:55Z

I support to use flash to replace clever-f and then users can freely choose whether to use it as a replacement for hop.

IMO hop, tree-hopper and incremental-selection covers the functionalities of flash very well and they are already in this repo. I'm also implementing folke/flash.nvim#52 on the top of TS.

And #494 (comment) cmp also enhance /

YuCao16 · 2023-08-02T17:01:34Z

I support to use flash to replace clever-f and then users can freely choose whether to use it as a replacement for hop.

They had the advantage over each other and I didn't remove hop.nvim, even though I use flash.nvim more often.

Jint-lzxy · 2023-08-02T17:05:05Z

I support to use flash to replace clever-f and then users can freely choose whether to use it as a replacement for hop.

Hmm FWIW this way the drawbacks of this plugin outweigh the potential benefits it may bring. I mean, why do we need to replace a single working plugin with a highly-integrated one? We can add wildfire.vim for custom textobjects and have each plugin do their respective functionality, which will also reduce maintenance pressure as no plugin will experience way faster iterations.

And #494 (comment) cmp also enhance /

Ah thanks for providing a working example! I'm working on this, trying to cover some cornercases 😄

YuCao16 · 2023-08-02T17:05:54Z

I support to use flash to replace clever-f and then users can freely choose whether to use it as a replacement for hop.

IMO hop, tree-hopper and incremental-selection covers the functionalities of flash very well and they are already in this repo. I'm also implementing folke/flash.nvim#52 on the top of TS.

And #494 (comment) cmp also enhance /

This is a little bit different IMO, flash.nvim also support fast jump in search mode, however, cmp and other plugins don't.

YuCao16 · 2023-08-02T17:08:21Z

I support to use flash to replace clever-f and then users can freely choose whether to use it as a replacement for hop.

Hmm FWIW this way the drawbacks of this plugin outweigh the potential benefits it may bring. I mean, why do we need to replace a single working plugin with a highly-integrated one? We can add wildfire.vim for custom textobjects and have each plugin do their respective functionality, which will also reduce maintenance pressure as no plugin will experience way faster iterations.

And #494 (comment) cmp also enhance /

Ah thanks for providing a working example! I'm working on this, trying to cover some cornercases smile

I've been using cmp-cmdline, because sometimes lsp integrate is needed in cmdline. but wilder.nvim's statusline is quite useful ...

Jint-lzxy · 2023-08-02T17:09:30Z

This is a little bit different IMO, flash.nvim also support fast jump in search mode, however, cmp and other plugins don't.

Maybe we can only enable this specific feature? b/c we'll probably load flash.nvim at { "CursorHold", "CursorHoldI" }, this way, its setup will unlikely to result in performance overhead.

Jint-lzxy · 2023-08-02T17:11:40Z

but wilder.nvim's statusline is quite useful ...

Yeah I'm trying to address this issue (if we can collect and import these missing items using external sources)

YuCao16 · 2023-08-02T17:12:05Z

Maybe we can only enable this specific feature?

You mean f, F and / or only f and F?

Jint-lzxy · 2023-08-02T17:19:00Z

You mean f, F and / or only f and F?

I mean we can only enable "fast jump in search mode". This way we can avoid introduing breaking changes - if users do want to activate some of flash's features, they can enable it themselves. To me, I tend to distribute functionalities to as many plugins as possible, as this reduces maintenance pressure by eliminating the need to frequently update a specific config (file). But this is just a matter of taste :) If a plugin can bring about better experience then, why not?

YuCao16 · 2023-08-02T17:28:03Z

You mean f, F and / or only f and F?

I mean we can only enable "fast jump in search mode". This way we can avoid introduing breaking changes - if users do want to activate some of flash's features, they can enable it themselves. To me, I tend to distribute functionalities to as many plugins as possible, as this reduces maintenance pressure by eliminating the need to frequently update a specific config (file). But this is just a matter of taste :) If a plugin can bring about better experience then, why not?

I agree, as if we should replace hop.nvim by flash.nvim is not my concern, everyone has their own preferences. For introducing this plugin:

clever-f has some bug, sometimes highlight won't clear.
flash.nvim offers fast jump in search mode.

aarnphm · 2023-08-02T17:29:47Z

I tend to agree with @Jint-lzxy, maybe we can introduce flash.nvim gradually, first for just f, and F. For search mode I think telescope should be more than enough

YuCao16 · 2023-08-02T17:40:24Z

For search mode I think telescope should be more than enough

I feel like I'm the author of 'flash.nvim' :D, but seems telescope can't do this.

Jint-lzxy · 2023-08-02T17:43:49Z

clever-f has some bug, sometimes highlight won't clear.

Hmm I haven't encountered this issue before, but clever-f does clear its highlight after some time. Is this related to ur issue?

I feel like I'm the author of 'flash.nvim' :D, but seems telescope can't do this.

Yeah that's why I said "we can only enable 'fast jump in search mode'"

YuCao16 · 2023-08-02T18:22:52Z

Hmm I haven't encountered this issue before, but clever-f does clear its highlight after some time. Is this related to ur issue?

I kind of forgot how to reproduce that bug, if I finish the JUMP then there is no highlight at that point. But when I press ; again (without pressing f), the highlight doesn't get cleared.

vollowx · 2023-08-02T23:30:07Z

Another thing, as flash takes place of statusline, and it's prompt is configurable, we can make it look like lualine section a, maybe better.

YuCao16 · 2023-08-02T23:32:33Z

Another thing, as flash takes place of statusline, and it's prompt is configurable, we can make it look like lualine section a, maybe better.

Good point, I will take a look in the morning.

CharlesChiuGit · 2023-08-07T10:52:23Z

Before I read the readme of flash.nvim, I was leaning toward Jint's side, which is distribute functionalities to each plugins, since we already had the experience of lspsaga.

But after reading the readme, I found it was THE motion plugin I ever wanted an year ago! If flash.nvim was created at that time, I think I will go all in on this.

Considering there might be lots of ppl using the repo, I think it would be better to replace one functionality/plugin at each release, as aarnphm implied.

Not sure about the status line thingy tho, I didn't look super deep into flash.nvim.

Jint-lzxy · 2023-08-07T11:30:05Z

Considering there might be lots of ppl using the repo, I think it would be better to replace one functionality/plugin at each release, as aarnphm implied.

Also quite in favor of this (as per #926 (comment)) - we can gradually complete such transition like what we did in #920 and #921. Cause from the user's perspective, those individual PRs only adds a few files, along with several trivial (and "conflict-friendly") changes that are easy to adopt. This can also effectively avoid breaking changes (which can be quite annoying in some cases).

ayamir · 2023-09-30T05:06:33Z

Maybe it's time to promote this PR @YuCao16 ?

YuCao16 · 2023-10-02T12:15:57Z

Maybe it's time to promote this PR @YuCao16 ?

Yes, give me sometime.

YuCao16 · 2023-10-21T17:27:45Z

Sorry for the long delay, what other changes do I need to make before merge? @Jint-lzxy @ayamir

ayamir · 2023-10-22T14:07:11Z

It's undoubted that flash.nvim's f/F/t/T function can replace clever-f.vim. But its other functions should be discussed if we want to replace more existing plugins.
IMO the jump function is enough to replace HopWord. But the search and jump function can't replace wilder.nvim because it doesn't support file level. Its remote function is wired for me and I can't understand its value.

YuCao16 · 2023-10-23T09:05:17Z

It's undoubted that flash.nvim's f/F/t/T function can replace clever-f.vim. But its other functions should be discussed if we want to replace more existing plugins.
IMO the jump function is enough to replace HopWord. But the search and jump function can't replace wilder.nvim because it doesn't support file level. Its remote function is wired for me and I can't understand its value.

My use case is that flash.nvim is a perfect replacement for clever-f, can be used with wilder, but replacing hop requires a bit of a learning curve. I don't even use remote, we don't need to configure all the features of a plugin.

Signed-off-by: ayamir <lgt986452565@gmail.com>

ayamir · 2023-10-24T02:52:56Z

IMO it's better to leave the decision to users. It looks good to me now.

lua/core/mapping.lua

Jint-lzxy

Sorry for the delay. This PR LGTM now 😸 I explicitly disabled flash.nvim's search mode integration (but kept the related keymap to facilitate user customization), b/c IMHO this may not be the point that some users expect to change, and there're compatibility issues with wilder.nvim (correct me if I'm wrong :D)

YuCao16 · 2023-10-30T13:24:44Z

Sorry for the delay. This PR LGTM now 😸 I explicitly disabled flash.nvim's search mode integration (but kept the related keymap to facilitate user customization), b/c IMHO this may not be the point that some users expect to change, and there're compatibility issues with wilder.nvim (correct me if I'm wrong :D)

I agree, LGTM, thanks for your help!

* disable enforce_regular_tabs to fix unique name not working * add flash.nvim * disable multi_window * fixup!: remove comment lines in keymap, add NOTEs for users. Signed-off-by: ayamir <lgt986452565@gmail.com> * move flash_ecs to keymap/helpers.lua and rename to _flash_esc * feat(flash): support user-override * pref: explicitly disable `flash.search` by default * chore: sort keymap helpers * fix typo * fixup! fix typo --------- Signed-off-by: ayamir <lgt986452565@gmail.com> Co-authored-by: ayamir <lgt986452565@gmail.com> Co-authored-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

disable enforce_regular_tabs to fix unique name not working

1f131de

Jint-lzxy changed the title ~~add plugin flash.nvim~~ feat: add flash.nvim Aug 2, 2023

Jint-lzxy marked this pull request as draft August 2, 2023 15:55

Jint-lzxy changed the title ~~feat: add flash.nvim~~ feat(plugins): add flash.nvim Aug 2, 2023

Jint-lzxy mentioned this pull request Aug 3, 2023

feat: replace wilder by cmp.cmdline #929

Closed

Merge remote-tracking branch 'upstream/main' into dev

39d9249

YuCao16 force-pushed the dev branch from 9a80f8e to 39d9249 Compare October 21, 2023 17:23

YuCao16 added 2 commits October 21, 2023 18:24

add flash.nvim

9eaceee

disable multi_window

0620e7c

fixup!: remove comment lines in keymap, add NOTEs for users.

043ae91

Signed-off-by: ayamir <lgt986452565@gmail.com>

ayamir approved these changes Oct 24, 2023

View reviewed changes

ayamir marked this pull request as ready for review October 24, 2023 02:53

ayamir requested review from CharlesChiuGit and Jint-lzxy October 24, 2023 02:53

Jint-lzxy requested changes Oct 24, 2023

View reviewed changes

lua/core/mapping.lua Outdated Show resolved Hide resolved

YuCao16 and others added 6 commits October 26, 2023 15:29

move flash_ecs to keymap/helpers.lua and rename to _flash_esc

82e8d86

feat(flash): support user-override

c1c6a83

pref: explicitly disable flash.search by default

23737b6

chore: sort keymap helpers

2293677

fix typo

578cdc5

fixup! fix typo

8e636bf

Jint-lzxy approved these changes Oct 30, 2023

View reviewed changes

Jint-lzxy changed the title ~~feat(plugins): add flash.nvim~~ feat(plugins): add flash.nvim to replace clever-f.nvim Oct 30, 2023

Jint-lzxy changed the title ~~feat(plugins): add flash.nvim to replace clever-f.nvim~~ feat(plugins): add flash.nvim to replace clever-f.vim Oct 30, 2023

ayamir merged commit e6a2d0a into ayamir:main Nov 1, 2023
2 checks passed

TonyWu20 mentioned this pull request Dec 8, 2023

ayamir main TonyWu20/nvimdots#31

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(plugins): add `flash.nvim` to replace `clever-f.vim` #926

feat(plugins): add `flash.nvim` to replace `clever-f.vim` #926

YuCao16 commented Aug 2, 2023

YuCao16 commented Aug 2, 2023 •

edited

Loading

Jint-lzxy commented Aug 2, 2023

YuCao16 commented Aug 2, 2023 •

edited

Loading

fecet commented Aug 2, 2023

YuCao16 commented Aug 2, 2023

Jint-lzxy commented Aug 2, 2023 •

edited

Loading

YuCao16 commented Aug 2, 2023

fecet commented Aug 2, 2023 •

edited

Loading

YuCao16 commented Aug 2, 2023

Jint-lzxy commented Aug 2, 2023

YuCao16 commented Aug 2, 2023

YuCao16 commented Aug 2, 2023

Jint-lzxy commented Aug 2, 2023

Jint-lzxy commented Aug 2, 2023

YuCao16 commented Aug 2, 2023

Jint-lzxy commented Aug 2, 2023 •

edited

Loading

YuCao16 commented Aug 2, 2023

aarnphm commented Aug 2, 2023

YuCao16 commented Aug 2, 2023 •

edited

Loading

Jint-lzxy commented Aug 2, 2023

YuCao16 commented Aug 2, 2023

vollowx commented Aug 2, 2023

YuCao16 commented Aug 2, 2023

CharlesChiuGit commented Aug 7, 2023 •

edited

Loading

Jint-lzxy commented Aug 7, 2023 •

edited by CharlesChiuGit

Loading

ayamir commented Sep 30, 2023

YuCao16 commented Oct 2, 2023

YuCao16 commented Oct 21, 2023 •

edited

Loading

ayamir commented Oct 22, 2023 •

edited

Loading

YuCao16 commented Oct 23, 2023

ayamir commented Oct 24, 2023

Jint-lzxy left a comment

YuCao16 commented Oct 30, 2023

feat(plugins): add flash.nvim to replace clever-f.vim #926

feat(plugins): add flash.nvim to replace clever-f.vim #926

Conversation

YuCao16 commented Aug 2, 2023

YuCao16 commented Aug 2, 2023 • edited Loading

Jint-lzxy commented Aug 2, 2023

YuCao16 commented Aug 2, 2023 • edited Loading

fecet commented Aug 2, 2023

YuCao16 commented Aug 2, 2023

Jint-lzxy commented Aug 2, 2023 • edited Loading

YuCao16 commented Aug 2, 2023

fecet commented Aug 2, 2023 • edited Loading

YuCao16 commented Aug 2, 2023

Jint-lzxy commented Aug 2, 2023

YuCao16 commented Aug 2, 2023

YuCao16 commented Aug 2, 2023

Jint-lzxy commented Aug 2, 2023

Jint-lzxy commented Aug 2, 2023

YuCao16 commented Aug 2, 2023

Jint-lzxy commented Aug 2, 2023 • edited Loading

YuCao16 commented Aug 2, 2023

aarnphm commented Aug 2, 2023

YuCao16 commented Aug 2, 2023 • edited Loading

Jint-lzxy commented Aug 2, 2023

YuCao16 commented Aug 2, 2023

vollowx commented Aug 2, 2023

YuCao16 commented Aug 2, 2023

CharlesChiuGit commented Aug 7, 2023 • edited Loading

Jint-lzxy commented Aug 7, 2023 • edited by CharlesChiuGit Loading

ayamir commented Sep 30, 2023

YuCao16 commented Oct 2, 2023

YuCao16 commented Oct 21, 2023 • edited Loading

ayamir commented Oct 22, 2023 • edited Loading

YuCao16 commented Oct 23, 2023

ayamir commented Oct 24, 2023

Jint-lzxy left a comment

Choose a reason for hiding this comment

YuCao16 commented Oct 30, 2023

feat(plugins): add `flash.nvim` to replace `clever-f.vim` #926

feat(plugins): add `flash.nvim` to replace `clever-f.vim` #926

YuCao16 commented Aug 2, 2023 •

edited

Loading

YuCao16 commented Aug 2, 2023 •

edited

Loading

Jint-lzxy commented Aug 2, 2023 •

edited

Loading

fecet commented Aug 2, 2023 •

edited

Loading

Jint-lzxy commented Aug 2, 2023 •

edited

Loading

YuCao16 commented Aug 2, 2023 •

edited

Loading

CharlesChiuGit commented Aug 7, 2023 •

edited

Loading

Jint-lzxy commented Aug 7, 2023 •

edited by CharlesChiuGit

Loading

YuCao16 commented Oct 21, 2023 •

edited

Loading

ayamir commented Oct 22, 2023 •

edited

Loading