Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add setting for copilot enable or not. #930

Merged
merged 2 commits into from
Aug 7, 2023
Merged

feat: add setting for copilot enable or not. #930

merged 2 commits into from
Aug 7, 2023

Conversation

ayamir
Copy link
Owner

@ayamir ayamir commented Aug 6, 2023

Not all users use copilot and not all situations we need it. So I add a switch to it. (Sorry for the wrong branch name)

@ayamir
feat: add setting for copilot enable or not.
c4c4d51 
Signed-off-by: ayamir <lgt986452565@gmail.com>
@CharlesChiuGit
Copy link
Collaborator

CharlesChiuGit commented Aug 7, 2023 •
edited
Loading

Would also adding other AI engines toggle to core/settings.lua make sense? like tabline and codeium.
But the PR for now works as expected.

@CharlesChiuGit
Copy link
Collaborator

CharlesChiuGit commented Aug 7, 2023 •
edited
Loading

hmmm, it made a mess when i tried to include tabline and codeium. maybe just leave them along.

@fecet
Copy link
Contributor

fecet commented Aug 7, 2023

maybe also good to add some other AI stuff like chatgpt.nvim

Jint-lzxy
Jint-lzxy approved these changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@Jint-lzxy Jint-lzxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we can leave this PR unchanged cause copilot has a large user base, thus shipping copilot with our base config makes sense to me. For those other plugins (possible candidates for extras), @fecet proposed in #888 (comment) that we can "use our custom loader (to) import extras like LazyVim". FWIW this is just trivial amount of work and can be implemented together w/ #931 😄

@ayamir
fix: make use_copilot true by default.
d0a3652 
Signed-off-by: ayamir <lgt986452565@gmail.com>
@ayamir
Copy link
Owner Author

ayamir commented Aug 7, 2023

Making it true by default won't influence the current user experience.

@ayamir
Copy link
Owner Author

ayamir commented Aug 7, 2023

maybe also good to add some other AI stuff like chatgpt.nvim

Haven't tried it because my free api key expired before lol

@ayamir ayamir merged commit 90e34ff into main Aug 7, 2023
4 checks passed
@ayamir ayamir deleted the fix/copilot-mod branch August 7, 2023 13:04
singlemancombat pushed a commit to singlemancombat/nvim-config that referenced this pull request Aug 7, 2023
@ayamir @singlemancombat
feat: add setting for copilot enable or not. (ayamir#930)
bf27b07 
Signed-off-by: ayamir <lgt986452565@gmail.com>
@TonyWu20 TonyWu20 mentioned this pull request Aug 21, 2023
Merged
@TonyWu20 TonyWu20 mentioned this pull request Sep 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jint-lzxy Jint-lzxy Jint-lzxy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ayamir @CharlesChiuGit @fecet @Jint-lzxy