refactor (user custom): Proposal for enhancing user customization experience #931

misumisumi · 2023-08-06T11:36:39Z

I proposed user custom isolation in #885, but changed many parts because it was an override using opts in lazy.nvim.
In #888, it was pointed out that the default definition might be read after the user definition if the lazy.nvim method is passed to opts.
In addition, it was pointed out that it would be possible to consider a configuration that can be overridden without making major changes to the current configuration, so we considered it again and implemented it.
At that time, I created a new branch, so I will throw a PR again.
Closing the previous PR.

…Don't create a file with the same name as `lua/modules/configs`)

…plugin

This reverts commit b127042.

…uced in 372d3c9

Jint-lzxy

Several general comments:

lua/core/event.lua

lua/core/options.lua

lua/core/pack.lua

lua/modules/utils/init.lua

lua/modules/utils/keymap.lua

Jint-lzxy

Some changes may require an update.

Co-authored-by: 冷酔閑吟 <50296129+Jint-lzxy@users.noreply.github.com> Signed-off-by: MiSumiSumi <dragon511southern@gmail.com>

… according to module location

…ugins were overridden.

Jint-lzxy · 2023-08-19T08:25:38Z

@CharlesChiuGit I fixed several trivial formatting issues and added some comments. Now the folder structure section aligns pretty well :)

misumisumi · 2023-08-19T08:31:53Z

@Jint-lzxy
I would appreciate it if you could reply to my review about load_plugins.

misumisumi · 2023-08-19T08:44:23Z

@Jint-lzxy @CharlesChiuGit
I think that bug_report.yml needs a check item to check if it has been started without user.
Also, if user is the cause, it is necessary to direct to custom-config.yml.

Jint-lzxy · 2023-08-19T08:47:36Z

I would appreciate it if you could reply to my review about load_plugins.

@misumisumi Oh sorry I missed that review, there are too many replies flying around this thread. May I ask which specific review you're referring to?

misumisumi · 2023-08-19T08:50:20Z

Please review the lua/modules/utils/init.lua just above.

Jint-lzxy · 2023-08-19T08:58:16Z

I think that bug_report.yml needs a check item to check if it has been started without user.
Also, if user is the cause, it is necessary to direct to custom-config.yml.

a789e3c

Jint-lzxy · 2023-08-19T09:07:52Z

Please review the lua/modules/utils/init.lua just above.

This looks pretty good to me lol

misumisumi · 2023-08-19T09:16:02Z

This looks pretty good to me lol

Do you mean that it's better to delete it?

Jint-lzxy · 2023-08-19T09:21:07Z

Do you mean that it's better to delete it?

I reviewed this version of utils/init.lua (which is marked as changed since your last review) and don't think we need to change anything. Have u pushed ur changes to GitHub?

misumisumi · 2023-08-19T09:24:40Z

No, I didn't change anything.
I got it.
thank you.

CharlesChiuGit · 2023-08-19T11:45:07Z

@CharlesChiuGit I fixed several trivial formatting issues and added some comments. Now the folder structure section aligns pretty well :)

LGTM!

CharlesChiuGit · 2023-08-20T05:24:05Z

Are we still waiting for the new wiki to complete?

Jint-lzxy · 2023-08-20T18:44:22Z

Are we still waiting for the new wiki to complete?

Yeah we're still waiting for that

misumisumi · 2023-08-23T04:09:39Z

@Jint-lzxy @CharlesChiuGit
Started a discussion about updating the wiki.

Signed-off-by: ayamir <lgt986452565@gmail.com>

ayamir · 2023-08-25T08:03:33Z

Can we merge it now?

misumisumi · 2023-08-25T08:36:24Z

The code has been reviewed and the wiki has been edited, so it should be fine.

…erience (ayamir#931) * feat(utils): Add `load_plugin` function * feat(pack.lua): Added loading of user custom plugins * feat(ui): Changes to `load_plugin()` * feat(tool): Changes to `load_plugin()` * feat(editor): Changes to `load_plugin()` * feat(lang): Changes to `load_plugin()` * feat(completion): Changes to `load_plugin()` * feat(keymap): Adding user overrides for keymap * feat(pack): Add `lua/user/modules/configs` to package.path (WARNING: Don't create a file with the same name as `lua/modules/configs`) * feat(event): Supports user-defined events * feat(options): Supports user-defined options * feat(settings): Supports user-defined settings * hotfix(pack): Incorrect value is added when there is no user-defined plugin * Revert "feat(keymap): Adding user overrides for keymap" This reverts commit b127042. * feat(keymap): Defining user keymaps with the override function introduced in 372d3c9 * feat(keymap): Support unset keymap. * Apply suggestions from code review Co-authored-by: 冷酔閑吟 <50296129+Jint-lzxy@users.noreply.github.com> Signed-off-by: MiSumiSumi <dragon511southern@gmail.com> * fix(pack): Change user_module_dir location and implement 'string:sub' according to module location * hotfix(utils): Fixed a bug that could not be loaded when vimscript plugins were overridden. * feat(utils): Create `config_extend` function * add(user): Create user config directory * feat(keymap): add `keymap.replace` function * add(user/keymap): Create user config directory for keymap * fix: cleanups & fixups * chore: remove unused function * feat(pack): add custom loader for user plugin config * feat(pack): add `disabled_plugins` to settings * update(.gitignore): add `lua/user` * fix(utils): Fixed an issue where lists with values were replaced instead of expanded * feat(lsp): Support user override for lsp settings * feat(utils): add `load_config()` to resolve and load `user.configs` * Revert "feat(utils): add `load_config()` to resolve and load `user.configs`" This reverts commit f95d110. * feat(modules/keymap): just remove the keymap * refactor(mason-*): Separating `mason-*` from `lspconfig` and `null-ls` * feat(mason_*_handler): If there is a user definition, it is read with priority * fix(pack): Abolish custom loader and add `lua/user` to rtp * add(user): Make `lsp-servers` and `dap-clients` directory * fix(user/keymap): Add override `core.keymap` * rename: Move `lsp-servers` and `dap-clients` under `user/configs` * chore: update comments Signed-off-by: Charles Chiu <charleschiu@hey.com> * chore: update comments Signed-off-by: Charles Chiu <charleschiu@hey.com> * chore: cleanup * style: Change position of user override * feat(issue template): add user config debug template Signed-off-by: Charles Chiu <charleschiu@hey.com> * chore(issue template): fix new template Signed-off-by: Charles Chiu <charleschiu@hey.com> * fix template Signed-off-by: Charles Chiu <charleschiu@hey.com> * test fix Signed-off-by: Charles Chiu <charleschiu@hey.com> * fix(issue template): syntax error Signed-off-by: Charles Chiu <charleschiu@hey.com> * fix(issue template): syntax error Signed-off-by: Charles Chiu <charleschiu@hey.com> * fixup(ISSUE_TEMPLATE): fix formatting&linting issues * fixup(IS_TEMPL): proper redirections to correct template * fix merge conflicts * feat: add colorscheme setting to example user settings. Signed-off-by: ayamir <lgt986452565@gmail.com> * feat: update tutor and settings. Signed-off-by: ayamir <lgt986452565@gmail.com> --------- Signed-off-by: MiSumiSumi <dragon511southern@gmail.com> Signed-off-by: Charles Chiu <charleschiu@hey.com> Signed-off-by: ayamir <lgt986452565@gmail.com> Co-authored-by: 冷酔閑吟 <50296129+Jint-lzxy@users.noreply.github.com> Co-authored-by: Charles Chiu <charleschiu@hey.com> Co-authored-by: ayamir <lgt986452565@gmail.com>

misumisumi added 16 commits August 6, 2023 20:04

feat(utils): Add load_plugin function

0dfd3f0

feat(pack.lua): Added loading of user custom plugins

acdb19c

feat(ui): Changes to load_plugin()

28c2493

feat(tool): Changes to load_plugin()

76f3792

feat(editor): Changes to load_plugin()

09f143d

feat(lang): Changes to load_plugin()

afd770b

feat(completion): Changes to load_plugin()

bee9b82

feat(keymap): Adding user overrides for keymap

8a8cc9d

feat(pack): Add lua/user/modules/configs to package.path (WARNING: …

9b14856

…Don't create a file with the same name as `lua/modules/configs`)

feat(event): Supports user-defined events

f3ddbcb

feat(options): Supports user-defined options

602e28c

feat(settings): Supports user-defined settings

2768952

hotfix(pack): Incorrect value is added when there is no user-defined …

12d63f5

…plugin

Revert "feat(keymap): Adding user overrides for keymap"

7ba6647

This reverts commit b127042.

feat(keymap): Defining user keymaps with the override function introd…

b07bb7c

…uced in 372d3c9

Merge branch 'upstream' into add-user-custom-function

7074b39

misumisumi mentioned this pull request Aug 6, 2023

About improvement of user customization experience. #888

Closed

7 tasks

feat(keymap): Support unset keymap.

98d7857

Jint-lzxy mentioned this pull request Aug 7, 2023

feat: add setting for copilot enable or not. #930

Merged

Jint-lzxy reviewed Aug 9, 2023

View reviewed changes

Jint-lzxy previously requested changes Aug 9, 2023

View reviewed changes

misumisumi force-pushed the add-user-custom-function branch 2 times, most recently from 57e91ca to ae7fb55 Compare August 9, 2023 07:27

Apply suggestions from code review

357738f

Co-authored-by: 冷酔閑吟 <50296129+Jint-lzxy@users.noreply.github.com> Signed-off-by: MiSumiSumi <dragon511southern@gmail.com>

misumisumi force-pushed the add-user-custom-function branch from ae7fb55 to 357738f Compare August 9, 2023 08:24

misumisumi added 5 commits August 9, 2023 18:01

fix(pack): Change user_module_dir location and implement 'string:sub'…

af2b56f

… according to module location

hotfix(utils): Fixed a bug that could not be loaded when vimscript pl…

bc691cf

…ugins were overridden.

feat(utils): Create config_extend function

18254b0

add(user): Create user config directory

aa60d4d

feat(keymap): add keymap.replace function

e2238a6

fixup(IS_TEMPL): proper redirections to correct template

a789e3c

Jint-lzxy force-pushed the add-user-custom-function branch from 165c8a2 to a789e3c Compare August 19, 2023 09:01

Jint-lzxy added 2 commits August 19, 2023 17:10

Merge branch 'main' into add-user-custom-function

bb29604

fix merge conflicts

8598ed1

misumisumi mentioned this pull request Aug 23, 2023

[doc] Wiki update about user custom. #968

Closed

feat: add colorscheme setting to example user settings.

fcf648f

Signed-off-by: ayamir <lgt986452565@gmail.com>

ayamir mentioned this pull request Aug 25, 2023

C-k <bs> not work in terminal windows #970

Closed

2 tasks

This was linked to issues Aug 25, 2023

About improvement of user customization experience. #888

Closed

[doc] Wiki update about user custom. #968

Closed

feat: update tutor and settings.

cd47c58

Signed-off-by: ayamir <lgt986452565@gmail.com>

ayamir merged commit 188a73e into ayamir:main Aug 25, 2023
2 checks passed

TonyWu20 mentioned this pull request Sep 22, 2023

ayamir main TonyWu20/nvimdots#27

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor (user custom): Proposal for enhancing user customization experience #931

refactor (user custom): Proposal for enhancing user customization experience #931

misumisumi commented Aug 6, 2023

Jint-lzxy left a comment

Jint-lzxy left a comment

Jint-lzxy commented Aug 19, 2023

misumisumi commented Aug 19, 2023

misumisumi commented Aug 19, 2023

Jint-lzxy commented Aug 19, 2023 •

edited

Loading

misumisumi commented Aug 19, 2023

Jint-lzxy commented Aug 19, 2023 •

edited

Loading

Jint-lzxy commented Aug 19, 2023

misumisumi commented Aug 19, 2023

Jint-lzxy commented Aug 19, 2023

misumisumi commented Aug 19, 2023

CharlesChiuGit commented Aug 19, 2023

CharlesChiuGit commented Aug 20, 2023

Jint-lzxy commented Aug 20, 2023

misumisumi commented Aug 23, 2023

ayamir commented Aug 25, 2023

misumisumi commented Aug 25, 2023

refactor (user custom): Proposal for enhancing user customization experience #931

refactor (user custom): Proposal for enhancing user customization experience #931

Conversation

misumisumi commented Aug 6, 2023

Jint-lzxy left a comment

Choose a reason for hiding this comment

Jint-lzxy left a comment

Choose a reason for hiding this comment

Jint-lzxy commented Aug 19, 2023

misumisumi commented Aug 19, 2023

misumisumi commented Aug 19, 2023

Jint-lzxy commented Aug 19, 2023 • edited Loading

misumisumi commented Aug 19, 2023

Jint-lzxy commented Aug 19, 2023 • edited Loading

Jint-lzxy commented Aug 19, 2023

misumisumi commented Aug 19, 2023

Jint-lzxy commented Aug 19, 2023

misumisumi commented Aug 19, 2023

CharlesChiuGit commented Aug 19, 2023

CharlesChiuGit commented Aug 20, 2023

Jint-lzxy commented Aug 20, 2023

misumisumi commented Aug 23, 2023

ayamir commented Aug 25, 2023

misumisumi commented Aug 25, 2023

Jint-lzxy commented Aug 19, 2023 •

edited

Loading

Jint-lzxy commented Aug 19, 2023 •

edited

Loading