Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Math] clamp function #111

Merged
merged 1 commit into from
Jan 18, 2021
Merged

[Math] clamp function #111

merged 1 commit into from
Jan 18, 2021

Conversation

veewee
Copy link
Collaborator

@veewee veewee commented Jan 18, 2021

This PR adds a Math\clamp($num, $min, $max) function that limits a number to a given range.

@veewee veewee requested a review from azjezz January 18, 2021 07:25
@coveralls
Copy link

coveralls commented Jan 18, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 493268052

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0008%) to 99.71%
Totals Coverage Status
Change from base Build 493237752: 0.0008%
Covered Lines: 2060
Relevant Lines: 2066
💛 - Coveralls

azjezz
azjezz reviewed Jan 18, 2021
View reviewed changes
src/Psl/Math/clamp.php Outdated Show resolved Hide resolved
azjezz
azjezz previously approved these changes Jan 18, 2021
View reviewed changes
src/Psl/Math/clamp.php Outdated Show resolved Hide resolved
@azjezz azjezz changed the base branch from 1.0.x to 1.1.x January 18, 2021 08:49
@azjezz azjezz dismissed their stale review January 18, 2021 08:49

The base branch was changed.

@veewee veewee force-pushed the math-clamp branch 2 times, most recently from 2dd4f8f to 885ac58 Compare January 18, 2021 08:53
azjezz
azjezz previously approved these changes Jan 18, 2021
View reviewed changes
@azjezz azjezz added this to the 1.1.0 milestone Jan 18, 2021
@azjezz azjezz added Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Type: Enhancement Most issues will probably ask for additions or changes. labels Jan 18, 2021
@azjezz azjezz merged commit 75484cc into azjezz:1.1.x Jan 18, 2021
@azjezz azjezz mentioned this pull request Jul 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azjezz azjezz azjezz approved these changes

Assignees
No one assigned
Labels
Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@veewee @coveralls @azjezz