Feature/27 downgrade v3 to php 74 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 add orderby
Merge pull request #20 from b24io/19-add-orderby
Added a new GitHub integration test workflow for the master and v4 branches using different PHP versions and operating systems. Removed the local .env file that contained application environment variables, these are now accessed as secrets in the new GitHub workflow for better security.
Add GitHub integration workflow and remove local .env file
The integration workflow file (.github/workflows/integration-v4.yml) was updated to use vars instead of secrets for the LOYALTY_API_ENDPOINT_URL. This change improves flexibility by allowing the URL to be updated more easily in the workflow runtime environment.
Update integration workflow to use vars for LOYALTY_API_ENDPOINT_URL
An echo has been added for the LOYALTY_API_ENDPOINT_URL environment variable in the Github action workflow file integration-v4.yml. This is useful for debugging purposes, providing visibility of the variable value during the workflow run.
These API keys used in the integration-v4 Github workflow have been removed for security purposes. The action now retrieves these keys from environment variables, ensuring more secure handling of sensitive data.
A new "environment" parameter has been added to the integration-v4.yml file. This change will
Altered assertions in ContactsFetcherTest and CardsFetcherTest to check for greater than or equal to expected counts, rather than exact match. Additionally, removed unnecessary debugging environment variable prints from integration-v4.yml in Github workflows.
Refactored the test assertions in ContactsFetcherTest, CardsFetcherTest, CardsTest, and ContactsTest files to ensure they are non-zero instead of comparing to the initial count. Also, a test method to count cards was added to the CardsTest file for better test coverage.
The PHP setup in the integration-v4.yml GitHub workflows file was updated. The version for setup-php was set to v2.30.4, the coverage was set to xdebug, and several PHP extensions (mbstring, intl,
This change is related to the PHP setup used in the GitHub Actions integration workflow. We've downgraded the "shivammathur/setup-php" action from version v2.30.4 to v2.9.0 to address compatibility issues.
The setup-php action used in the integration workflow has been updated to version 2.30.4. This change ensures that we use the latest available version, potentially benefiting from any improvements and bug fixes offered in the new release.
The Command class has been refactored to use a traditional constructor, where class properties are manually declared and set within the constructor. This replaces the previous approach that automatically set these properties through the constructor's parameters.
A Dockerfile for a PHP 7.4 command-line interface (CLI) environment on Alpine Linux has been added. It includes the installation of necessary PHP extensions, Composer, and other dependencies. The working directory is set to /var/www/html. Signed-off-by: B24io <app@b24.io>
The Credentials class has been refactored to provide readonly access to attributes. For the Context class, it has been changed from an enum to a class with additional validation in its constructor and methods to check the type of context. It now includes methods to verify whether the context is user, admin, or default. Signed-off-by: B24io <app@b24.io>
The trailing commas in BadRequestException.php and InternalServerErrorException.php after the $previous parameter have been removed. This small clean-up ensures better code consistency and adherence to the coding standards of the project. Signed-off-by: B24io <app@b24.io>
3 tasks
b24io-sdk
had a problem deploying
to
integration-tests
GitHub Actions
Failure
b24io-sdk
had a problem deploying
to
integration-tests
GitHub Actions
Failure
b24io-sdk
had a problem deploying
to
integration-tests
GitHub Actions
Failure
b24io-sdk
had a problem deploying
to
integration-tests
GitHub Actions
Failure
The PHP version used in the PHPStan GitHub workflow has been updated. Previously Signed-off-by: B24io <app@b24.io>
Updated the DTO classes Metadata, ResponseData, and Pagination to not be read-only, and added explicit property definitions. The constructors for these classes were refactored to follow a more traditional pattern, with properties being assigned inside the constructor body rather than through public property promotion in the parameter list Signed-off-by: B24io <app@b24.io>
Removed 'readonly' attribute from properties in ApiProblem and Response classes and introduced classic setters in constructor. This is a part of an ongoing initiative to refactor our codebase for better readability and maintainability. This change also improves compatibility with various PHP versions. Signed-off-by: B24io <app@b24.io>
Implemented new static methods in the Context class to create default, user, and admin contexts. Refactored the Core class to simplify checks for the existence of the itemsOrder attribute. Made changes in the AbstractItem class to change typing for array offset access methods and improve code readability. Signed-off-by: B24io <app@b24.io>
This commit updates the SDK version from '3.0.0' to '3.2.0' in ApiClient.php. Simultaneously, it refactors how 'context' is accessed and utilized within the same class. Now, rather than accessing the context's name, it uses the context directly and checks if it's an admin via an 'isAdmin()' method. Signed-off-by: B24io <app@b24.io>
Removed the readonly constraint from the TransactionsReader class to allow for property modification. The LoggerInterface has been introduced as a private Signed-off-by: B24io <app@b24.io>
This commit includes the addition of various new files related to tests, admin transactions, and cards. It also updates existing files by modifying certain functions and improving the code structure, and integrates GitHub workflows for v3. Numerous changes were made to improve code readability and functionality. The added files include new HTTP requests and responses for conducting tests and admin operations. Signed-off-by: B24io <app@b24.io>
The PHPStan command previously used in the ".github/workflows/phpstan.yml" workflow file was updated to "make lint-phpstan". This ensures that the correct task is run during automated checks. Signed-off-by: B24io <app@b24.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.