How to disable internal Attributes for component.MarkupMatches(expected);

[samtrion]

Is there a way to exclude the Blazor internal attributes __internal_stopPropagation_<eventname> and __internal_preventDefault_<eventname> from the component.MarkupMatches(expected); without marking each occurrence with :ignore?

[samtrion]

Maybe with a code extension here? Something like this

public static bool IsBlazorAttribute(string attributeName)
    => attributeName.StartsWith(BLAZOR_ATTR_PREFIX, StringComparison.Ordinal)
    || attributeName.StartsWith("__internal_stopPropagation_", StringComparison.Ordinal)
    || attributeName.StartsWith("__internal_preventDefault_", StringComparison.Ordinal);

[egil]

Hey @samtrion

Yeah, the specific attributes Blazor adds to the markup is handled in the Htmlizer class, so something like that would need to be added there.

Can you show me the component that generates the markup?

I will definitely add a fix in the next release.

ps. thanks for bringing this to my attention!

[egil]

And to answer your question, yes, I think the best solution for now is to use :ignore everywhere for now. I do hope to have a new release in a few weeks, that could include this, so they at that point become redundant.

If you want to help out with a PR on this, I would appreciate it. PRs should target the DEV branch.

Without having given much thought to a solution, I think that it should actually be handled in the same way as event-handler-trackers, by changing the attribute name to have the BLAZOR_ATTR_PREFIX prefix, making it play nice with the existing comparison/diffing logic, without any additions, probably adding another specific case to the switch statement in the file: https://github.com/egil/bunit/blob/master/src/Rendering/Internal/Htmlizer.cs#L220

[samtrion]

Will create a PR.

Use an internally created variant for now, until the next release.

[egil]

Awesome, much appreciated. Be warned, the project structure in the DEV branch has changed significantly. You will find Htmlizer.cs in the bunit.web project now - https://github.com/egil/bunit/blob/dev/src/bunit.web/Rendering/Internal/Htmlizer.cs.

[samtrion]

PR was created.

Sorry about the Spacing Disaster.

[egil]

NO worries. Added my review. Ill just squash in the end.