Fixed Internal Attributes #111 #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: samtrion <me@samtrion.net>
egil
reviewed
Apr 30, 2020
Co-Authored-By: Egil Hansen <egil@assimilated.dk>
egil
approved these changes
Apr 30, 2020
Signed-off-by: samtrion <me@samtrion.net>
Signed-off-by: samtrion <me@samtrion.net>
egil
requested changes
Apr 30, 2020
There was a problem hiding this comment.
Thanks for the test. As I read the test though, it actually tests that MarkupMatches correctly ignores the special Blazor attributes, and not that we correctly prefix all special Blazor attributes.
We do actually still render the attributes, so what you probably can do to write a test for this scenario, is to use a css query for the element with the click handler, and verify that it contains the attributes as expected, with the proper prefixed name. Makes sense?
Thanks again for your help.
Signed-off-by: samtrion <me@samtrion.net>
|
Guess that should fit so far. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: samtrion me@samtrion.net