plugin(analytics-provider-segment): migration of analytics-provider-segment plugin to backstage/community-plugins workspace

[Fortune-Ndlovu]

Hey, I just made a Pull Request!

The analytics-provider-segment plugin from the janus-idp/backstage-plugins repository was migrated to the community plugins. The migration was performed by following the manual migration steps outlined in the Community Plugins CONTRIBUTING guide

✔️ Checklist

• A changeset describing the change and affected packages. (more info)
• Added or updated documentation
• Tests for new functionality and regression tests for bug fixes
• Screenshots attached (for UI changes)
• All your commits have a Signed-off-by line in the message. (more info)

[backstage-goalie]

Missing Changesets

The following package(s) are changed by this PR but do not have a changeset:

• @backstage-community/plugin-analytics-module-ga
• @backstage-community/plugin-analytics-module-ga4
• @backstage-community/plugin-analytics-module-newrelic-browser

See CONTRIBUTING.md for more information about how to add changesets.

Changed Packages

Package Name	Package Path	Changeset Bump	Current Version
@backstage-community/plugin-analytics-module-ga	workspaces/analytics/plugins/analytics-module-ga	none	v0.2.9
@backstage-community/plugin-analytics-module-ga4	workspaces/analytics/plugins/analytics-module-ga4	none	v0.2.11
@backstage-community/plugin-analytics-module-newrelic-browser	workspaces/analytics/plugins/analytics-module-newrelic-browser	none	v0.1.9
@backstage-community/plugin-analytics-provider-segment	workspaces/analytics/plugins/analytics-provider-segment	patch	v1.10.1

[Fortune-Ndlovu]

cc: @04kash / @nickboldt

[awanlin]

Should this live in the analytics workspace? https://github.com/backstage/community-plugins/tree/main/workspaces/analytics

[04kash]

Should this live in the analytics workspace? https://github.com/backstage/community-plugins/tree/main/workspaces/analytics

Hmm yeah I think so too, WDYT @Fortune-Ndlovu ?

[Fortune-Ndlovu]

Agreed, moving...

[backstage-goalie]

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

[Fortune-Ndlovu]

Thanks, @04kash, @awanlin!

[04kash]

Looks good! Just need to add a changeset

[nickboldt]

Needs an update to CODEOWNERS. See example in https://github.com/backstage/community-plugins/pull/1912/files

[04kash]

I see some unrelated commits as a part of this PR eg: d89bfc2, not sure how they got here

[04kash]

I'm good with merging after this comment is addressed: #1896 (comment)

[christoph-jerolimov]

We don't use turbo here, you can just remove that config.

[christoph-jerolimov]

It would surprise me if we need this dependency. But there was also in the old code base. We can remove them also in a follow-up PR!

[christoph-jerolimov]

I don't know that plugin, this would be great, but it looks like it doesn't work as expected or do we need this for the other modules as well?

I think we should avoid extra prettier rules when possible.

Wdyt @awanlin @04kash ?

[christoph-jerolimov]

I saw that in different PRs, can we stay with the old order? I know, its an automated change, but this diff looks odd to me.

I didn't checked yet which config is responsible. Ping me if I should take a deeper look why some workspaces or plugins do this change and others not.

Wdyt @awanlin @04kash ?

[christoph-jerolimov]

Thanks for adding @schultzp2020 and me, but are we hi-jacking another workspace here?

@jmezach, is it fine for you if we just take care of the extra modules here, or are you fine if we also approve code changes to your modules?

Or, @awanlin @BethGriggs @04kash, should we consider adding additional lines here just for the module(s) we added? It's this PR for Google Analytics and #1906 for Matomo.

I just want to be a kindful and transparent citizen of this repo. ☮️ ✌️

[awanlin]

I've added this as a topic for the next Community SIG, but my thinking is to have paths to each plugin in the CODEOWNERS file. @jmezach contributed the New Relic analytics plugin, the GA ones are from Spotify from what I can remember.