-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugin(analytics-provider-segment): migration of analytics-provider-segment plugin to backstage/community-plugins workspace #1896
Closed
Fortune-Ndlovu
wants to merge
27
commits into
backstage:main
from
Fortune-Ndlovu:migrate-analytics-provider-segment
Closed
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
049d760
Initial workspace
Fortune-Ndlovu c5fe3b3
Added plugin and updated naming convention
Fortune-Ndlovu d3553cb
update lock file
Fortune-Ndlovu 70d9728
Changeset added
Fortune-Ndlovu 8241567
Fixed formatting issues in .prettierrc.js
Fortune-Ndlovu 841589e
Generated API report for analytics-provider-segment
Fortune-Ndlovu c372e5d
Update development dependency
Fortune-Ndlovu 7bfabff
provide consistent naming convention
Fortune-Ndlovu d85a4e3
move analytics-provider-segment to analytics workspace
Fortune-Ndlovu deefaa3
Remove old analytics-provider-segment files after move
Fortune-Ndlovu 355d182
fix build api step
Fortune-Ndlovu a4e6ff8
upgrade @backstage/repo-tools after adding ae-undocumented to buil:ap…
Fortune-Ndlovu d89bfc2
confluence-collator: make parallelismLimit optional (#1820)
mtlewis dd3f04c
Version Packages (#1899)
backstage-service 373a33f
Update API report for analytics-provider-segment
Fortune-Ndlovu c94583d
allow all warnings
Fortune-Ndlovu 6e0aa06
confluence-collator: make parallelismLimit optional (#1820)
mtlewis 14fb9ab
Version Packages (#1899)
backstage-service 4c7a32b
Deduplicated dependencies in yarn.lock for analytics workspace
Fortune-Ndlovu 5e45d16
confluence-collator: make parallelismLimit optional (#1820)
mtlewis bed2860
Version Packages (#1899)
backstage-service 6402213
changeset added!
Fortune-Ndlovu 49b4c2b
Update changeset for analytics-provider-segment migration to patch ve…
Fortune-Ndlovu 09d424b
Merge branch 'main' into migrate-analytics-provider-segment
Fortune-Ndlovu 390573a
fixup
Fortune-Ndlovu 49b2a53
add CODEOWNERS
Fortune-Ndlovu 08cd245
Merge branch 'backstage:main' into migrate-analytics-provider-segment
Fortune-Ndlovu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@backstage-community/plugin-analytics-provider-segment': patch | ||
christoph-jerolimov marked this conversation as resolved.
Show resolved
Hide resolved
|
||
--- | ||
|
||
The analytics-provider-segment plugin from the janus-idp/backstage-plugins repository was migrated to the community plugins, The migration was performed by following the manual migration steps outlined in the Community Plugins CONTRIBUTING guide, and ensuring the naming conventions aligned with the backstage-community standards. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,15 +13,15 @@ | |
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
import React from 'react'; | ||
import { createDevApp } from '@backstage/dev-utils'; | ||
import { Playground } from './Playground'; | ||
import { | ||
analyticsApiRef, | ||
configApiRef, | ||
identityApiRef, | ||
} from '@backstage/core-plugin-api'; | ||
import { createDevApp } from '@backstage/dev-utils'; | ||
import React from 'react'; | ||
import { GoogleAnalytics } from '../src'; | ||
import { Playground } from './Playground'; | ||
Comment on lines
+21
to
+24
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
createDevApp() | ||
.registerApi({ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
workspaces/analytics/plugins/analytics-provider-segment/.eslintignore
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
dist-dynamic | ||
dist-scalprum |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding @schultzp2020 and me, but are we hi-jacking another workspace here?
@jmezach, is it fine for you if we just take care of the extra modules here, or are you fine if we also approve code changes to your modules?
Or, @awanlin @BethGriggs @04kash, should we consider adding additional lines here just for the module(s) we added? It's this PR for Google Analytics and #1906 for Matomo.
I just want to be a kindful and transparent citizen of this repo. ☮️ ✌️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added this as a topic for the next Community SIG, but my thinking is to have paths to each plugin in the
CODEOWNERS
file. @jmezach contributed the New Relic analytics plugin, the GA ones are from Spotify from what I can remember.