-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update page.file source path with original source, fixes #12 #13
Conversation
@timvink Thanks for the PR! Looks good to me. Before I merge, there's two things:
Let me know if you need more guidance, hoping we can ship this change soon! :) |
Thanks for the guidance! I added the unit tests. I had to add Note that I fixed the versions of the plugins in Let me know if there is anything else I can improve :) |
Hi @bih, is there any chance we could move this solution forward? Can I help in any way? |
@pauloribeiro-codacy @timvink Finally got around to merging this. Sorry for the waiting on your side folks! :-) |
Just tried updating to this. It was working fine before this change, and now I'm getting a
@bih any idea? |
I also ran into the same issue. Here's the traceback:
|
Hmm, that's not good. I'm having trouble reproducing this locally. Which plugins do you have activated? Doing Somehow these files were not registered when the mono repo merged the docs: I need to figure out why.. update: OK i figured out the problem: it has to due with folders inside a |
Yes, I was also noticing this. In the traceback the temporary folder mentions:
But the Markdown file is actually in a
|
I believe we still have an incompatibility with the git-revision-date-localized plugin. When I have both plugins activated, Git does not detect the temporary folder as a local Git repository:
This is just a wild guess, but could it be that the |
OK that's unfortunate. Thanks for the persistent reports, really helpful ! I did some more research and here's what's going on: 1. bats testing not workingAll units tests pass, but the follow fails with the mkdocs build -f __tests__/integration/fixtures/ok-mkdocs-git-revision-date-localized-plugin/mkdocs.yml --> @bih Perhaps this is something you can fix on your end, as it seems like something is wrong with bats? Not urgent though. 2. Finding the
|
Thanks @timvink, the workaround of reordering the plugins in the |
* Fix when using plugin on windows * fix(test): update test * fix(version): bump version and update changelog Co-authored-by: Emma Indal <emmai@spotify.com>
This approach uses the
on_pre_page
event to update the page absolute source path attribute. It should fix issues when combiningmkdocs-monorepo-plugin
with plugins that depend on that attribute, like mkdocs-git-authors-plugin and mkdocs-git-revision-date-localized-plugin.