Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: Update mkdocs-monorepo-plugin to 0.4.7 #49

Merged
merged 2 commits into from
Jun 5, 2020

Conversation

prcr
Copy link
Contributor

@prcr prcr commented Jun 4, 2020

Update the mkdocs-monorepo-plugin to fix an the incompatibility issue that prevented displaying the last updated date on the generated pages:

backstage/mkdocs-monorepo-plugin#12

@prcr prcr requested a review from mrfyda June 4, 2020 06:55
@prcr prcr marked this pull request as draft June 4, 2020 06:56
@prcr prcr removed the request for review from mrfyda June 4, 2020 06:56
@prcr
Copy link
Contributor Author

prcr commented Jun 4, 2020

🚧 We're hitting this issue, so let's wait until it's fixed:

backstage/mkdocs-monorepo-plugin#13 (comment)

Includes an hotfix for a bug identified in 0.4.6.
@prcr prcr changed the title bump: Update mkdocs-monorepo-plugin to 0.4.6 bump: Update mkdocs-monorepo-plugin to 0.4.7 Jun 5, 2020
@prcr
Copy link
Contributor Author

prcr commented Jun 5, 2020

I'm now bumping the version to 0.4.7, which already includes the hotfix for the issue found previously.

@prcr prcr requested a review from mrfyda June 5, 2020 13:55
@prcr prcr marked this pull request as ready for review June 5, 2020 13:55
@mrfyda mrfyda merged commit 5dc4d02 into master Jun 5, 2020
@mrfyda mrfyda deleted the bump/mkdocs-monorepo-plugin branch June 5, 2020 14:01
@prcr
Copy link
Contributor Author

prcr commented Jun 5, 2020

I just found yet another issue... But eventually we'll get there! 😅

backstage/mkdocs-monorepo-plugin#13 (comment)

@prcr
Copy link
Contributor Author

prcr commented Jun 8, 2020

I just found yet another issue... But eventually we'll get there!

spotify/mkdocs-monorepo-plugin#13 (comment)

There's now a workaround for this issue:

backstage/mkdocs-monorepo-plugin#13 (comment)

I'm activating the plugin in this other pull request: #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants