Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated dependencies list #19

Closed
OrkoHunter opened this issue Mar 12, 2021 · 2 comments · Fixed by #24
Closed

Remove duplicated dependencies list #19

OrkoHunter opened this issue Mar 12, 2021 · 2 comments · Fixed by #24
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@OrkoHunter
Copy link
Member

We have listed Python dependencies in two places for this project

  1. https://github.com/backstage/mkdocs-techdocs-core/blob/main/requirements.txt
  2. install_requires in https://github.com/backstage/mkdocs-techdocs-core/blob/main/setup.py

This can cause inconsistencies when upgrading versions (like #18). So we should keep just one - possibly reuse data from requirements.txt in install_requires of setup.py.

@OrkoHunter OrkoHunter added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 12, 2021
@iamansoni
Copy link
Contributor

I would like to work on this task; you can assign it to me.
Also, will it be a good solution if I make requirements.txt to be read as a file in the setup.py and pass it as a list of strings to install_requires ?

@OrkoHunter
Copy link
Member Author

Sounds good to me. @iamansoni

TechDocs project board automation moved this from Incoming to Done ✅ Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants