Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade plantuml-markdown to 3.4.2 #18

Merged
merged 2 commits into from
Mar 22, 2021
Merged

Conversation

Crevil
Copy link
Contributor

@Crevil Crevil commented Mar 12, 2021

The plantuml-markdown module has received a handful of bug fixes and new features. This change upgrades it to the latest version available.

Notable changes are the possibility for including plantuml files from files introduced in 3.3.0.

Complete changelog available here: https://github.com/mikitex70/plantuml-markdown/blob/master/CHANGELOG.md

The plantuml-markdown module has received a handful of bug fixes and new features. This change upgrades it to the latest version available.

Notable changes are the possibility for including plantuml files from files introduced in 3.3.0.
@Crevil Crevil requested a review from a team as a code owner March 12, 2021 09:46
@OrkoHunter OrkoHunter added this to Incoming in TechDocs project board via automation Mar 12, 2021
@Crevil
Copy link
Contributor Author

Crevil commented Mar 12, 2021

Looks like a GitHub token is missing for the Triage check...

https://github.com/backstage/mkdocs-techdocs-core/pull/18/checks?check_run_id=2093830056#step:3:8

@OrkoHunter
Copy link
Member

Sure! Could you follow the steps here to helps us make a release with this PR?
https://github.com/backstage/mkdocs-techdocs-core#release-flow

Yeah the triaging doesn't work for PRs created from forks due to GitHub token not being shared. sad

@Crevil
Copy link
Contributor Author

Crevil commented Mar 12, 2021

@OrkoHunter updated the changelog. Testing it locally it seems I needed to update the plantuml-markdown version in setup.py as well. I'm not familiar with Pyton so let me know if updating that field was a mistake.

@OrkoHunter
Copy link
Member

Oh no, we have duplicated dependencies list. :/ Should just keep requirements.txt and re-use it.

But thanks for updating there as well!

@OrkoHunter OrkoHunter moved this from Incoming to To Review/Review In Progress ⏳ in TechDocs project board Mar 12, 2021
@emmaindal emmaindal merged commit c839d0b into backstage:main Mar 22, 2021
TechDocs project board automation moved this from To Review/Review In Progress ⏳ to Done ✅ Mar 22, 2021
@Crevil Crevil deleted the patch-1 branch March 22, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants