Updated setup.py #24
Merged
Updated setup.py #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added requirements.txt to be read as a file in the setup.py and passed it as a list of strings to install_requires.
|
Thank you @iamansoni for contributing with this change. I can see the linter is not happy, if you can look into that it would be great and then also add a one-liner in the changelog as well as a version bump in setup.py and we are ready to merge this! |
Addressed the issue of linter; and made a version bump.
Merged
|
I don't know why I'm still receiving the black lint issue; I've checked it on my local system and the code turns out to be working fine over there.
|
Signed-off-by: Emma Indal <emmai@spotify.com>
Seems like it was just a few spaces that caused the issue. I pushed an update so it should be ready to get merged. Thank you for the contribution 🎉 |
viccie30
added a commit
to viccie30/mkdocs-techdocs-core
that referenced
this pull request
Jun 22, 2023
PR backstage#24 deduplicated the requirements, but this makes the sdist on PyPi fail to build, because requirements.txt is not included. This fix includes requirements.txt using MANIFEST.in and changes the publication workflow to use build instead of calling setup.py directly. build always builds the wheel from the sdist, so this error is prevented in the future.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19
Reused data from
requirements.txtininstall_requiresofsetup.py