Fix build from sdist #130
Closed
Fix build from sdist #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR backstage#24 deduplicated the requirements, but this makes the sdist on PyPi fail to build, because requirements.txt is not included. This fix includes requirements.txt using MANIFEST.in and changes the publication workflow to use build instead of calling setup.py directly. build always builds the wheel from the sdist, so this error is prevented in the future.
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #24 deduplicated the requirements, but this makes the sdist on PyPi fail to build, because requirements.txt is not included.
This fix includes requirements.txt using MANIFEST.in and changes the publication workflow to use build instead of calling setup.py directly. build always builds the wheel from the sdist, so this error is prevented in the future.