Skip to content

Commit

Permalink
Make a few github tests more reliable (#2292)
Browse files Browse the repository at this point in the history
The version test is failing because the shields repo version is not a dotted version.
  • Loading branch information
paulmelnikow authored Nov 8, 2018
1 parent e240409 commit 611e58e
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions services/github/github.tester.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ const {
isFileSize,
isFormattedDate,
isVPlusDottedVersionAtLeastOne,
isSemver,
} = require('../test-validators')
const colorscheme = require('../../lib/colorscheme.json')
const { licenseToColor } = require('../../lib/licenses')
Expand Down Expand Up @@ -472,7 +473,7 @@ t.create('Package version')
.expectJSONTypes(
Joi.object().keys({
name: 'package',
value: isVPlusDottedVersionAtLeastOne,
value: isSemver,
})
)

Expand Down Expand Up @@ -639,12 +640,12 @@ t.create('downloads for unknown release')

t.create('hit counter')
.get('/search/torvalds/linux/goto.json')
.timeout(8000)
.timeout(10000)
.expectJSONTypes(Joi.object().keys({ name: 'goto counter', value: isMetric }))

t.create('hit counter for nonexistent repo')
.get('/search/torvalds/not-linux/goto.json')
.timeout(8000)
.timeout(10000)
.expectJSON({ name: 'goto counter', value: 'repo not found' })

t.create('commit activity (1 year)')
Expand Down

0 comments on commit 611e58e

Please sign in to comment.