Make a few [github] tests more reliable #2292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version test is failing because the shields repo version is not a dotted version
paulmelnikow
added
the
service-badge
PyvesB
approved these changes
Nov 8, 2018
Generated by 🚫 dangerJS |
|
On the first run, it timed out at 10 seconds. I wonder if we should remove these hit counter badges; the underlying API really doesn't work well enough. They only work if the badges are cached for a long time, like a day or a week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version test is failing because the shields repo version is not a dotted version.
Ref: #1359