Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove logoWidth param #10285

Open
chris48s opened this issue Jun 21, 2024 · 0 comments
Open

remove logoWidth param #10285

chris48s opened this issue Jun 21, 2024 · 0 comments
Labels
core Server, BaseService, GitHub auth

Comments

@chris48s
Copy link
Member

馃搵 Description

Shields exposes a param called logoWidth.
It is not very useful and doesn't really do what you would expect it to do, but it does exist.
https://img.shields.io/badge/foo-bar-blue?logo=javascript
https://img.shields.io/badge/foo-bar-blue?logo=javascript&logoWidth=50
This is really a hangover from the "popout" style which was removed in #3747
Tbh, we probably should have got rid of it then, but we didn't.

I propose we remove this param.
Passing it in the query string or an endpoint badge response should not throw an error, but it should also have no effect. We should remove it from the documentation.

The process should look similar to #10284 which removes the logoPosition param (which already did nothing).

@chris48s chris48s added the core Server, BaseService, GitHub auth label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Server, BaseService, GitHub auth
Projects
None yet
Development

No branches or pull requests

1 participant