Remove logoPosition
#10284
Merged
Remove logoPosition
#10284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris48s
commented
Jun 21, 2024
| Although this does nothing, | ||
| passing it should not throw an error | ||
| */ | ||
| logoPosition: optionalNumberWhenAnyLogoPresent, |
There was a problem hiding this comment.
I've left this in the schema so it is not a breaking change
This was referenced Jun 21, 2024
calebcartwright
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3747 we removed the popout style. Since then, the remnants of the
logoPositionparam have been knocking about. We really should have removed this at the time.This came up in the review of #9645 where @zavoloklom suggested removing it but provided an incomplete implementation. In this PR, I have completed the job.
Removing this seems like a no-brainer as it is just cruft. Passing
logoPositionas a URL param or in the endpoint badge already does nothing.